New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers: fix typos in doxygen #8564

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
5 participants
@kegilbert
Contributor

kegilbert commented Oct 26, 2018

Description

Typo fixes in Doxygen for Drivers.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change
@cmonr

cmonr approved these changes Oct 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 29, 2018

@kegilbert Anothre rebase, plx.

@AnotherButler When you get a chance to review.

@cmonr cmonr added needs: work and removed needs: review labels Oct 29, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 30, 2018

@kegilbert Another "Anothre rebase, plx." plx

@cmonr cmonr added needs: CI and removed needs: work labels Oct 30, 2018

@kegilbert kegilbert force-pushed the kegilbert:driver-doxy-typo-fix branch from 0eaf422 to 3532a15 Oct 30, 2018

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 30, 2018

@cmonr rebased

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 30, 2018

@kegilbert Rip. Docs failures.

@cmonr cmonr added needs: work and removed needs: CI labels Oct 30, 2018

@kegilbert kegilbert force-pushed the kegilbert:driver-doxy-typo-fix branch from 3532a15 to e8e9076 Oct 30, 2018

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 30, 2018

Updated, missed a merge conflict grumble grumble. Are the doxy update fixes in so Travis is catching these now?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 30, 2018

Updated, missed a merge conflict grumble grumble. Are the doxy update fixes in so Travis is catching these now?

#8593 will update the binary, but disable failure on the specific check. I don't have the bandwidth to learn and track down the doxygen issues atm, but the stdout is still enabled so that someone else can.

Once those issues are fixed, the updated command in that PR can be uncommented, enabled, and merged.

@cmonr cmonr added needs: CI and removed needs: work labels Oct 30, 2018

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Oct 30, 2018

Thanks, sounds good. I can try to take a look at the backlog of new Doxy warnings.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 30, 2018

Thanks, sounds good. I can try to take a look at the backlog of new Doxy warnings.

🎉 🐦

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 31, 2018

Build : SUCCESS

Build number : 3510
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8564/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 31, 2018

@0xc0170 0xc0170 changed the title from Fix typos in Drivers doxygen to Drivers: fix typos in doxygen Oct 31, 2018

@0xc0170 0xc0170 merged commit 8976709 into ARMmbed:master Oct 31, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 546 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9166 cycles (-95 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment