New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move #endif to fix PwmOut.h doxygen #8572

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
3 participants
@c1728p9
Contributor

c1728p9 commented Oct 29, 2018

Description

Move the #endif up so it does not include the closing bracket of PwmOut. This allows the doxygen for PwmOut, classmbed_1_1_pwm_out.html, to build.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Move #endif to fix PwmOut.h doxygen
Move the #endif up so it does not include the closing bracket of
PwmOut. This allows the doxygen for PwmOut, classmbed_1_1_pwm_out.html,
to build.
@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 29, 2018

This problem was introduced in #8412

@cmonr

cmonr approved these changes Oct 29, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 29, 2018

@c1728p9 What was the command that allowed you to build the file?

Looking into doxygen issues atm, and wondering if this is related to #8574

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 29, 2018

Hi @cmonr I used the command

> doxygen doxyfile_options
@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 29, 2018

@c1728p9 doxygen --version ?

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Oct 29, 2018

I'm using doxygen version 1.8.10

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 29, 2018

@c1728p9 Thanks for the datapoint!

@cmonr cmonr added the rollup PR label Oct 29, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 29, 2018

Now that I'm taking another look at this, I'm really bothered that CI didn't catch it...

@0xc0170 0xc0170 merged commit 3b970c1 into ARMmbed:master Oct 30, 2018

11 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9893 cycles (-31 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Oct 30, 2018

@cmonr cmonr removed the rollup PR label Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment