New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile export with Python 3 #8577

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
6 participants
@lassebm
Contributor

lassebm commented Oct 29, 2018

Description

In Python 3, the map() function returns a map object, not a list object as in
Python 2. Ensure a list object is returned from format_flags() by wrapping
map() in list(). This is compatible with both Python 2 and 3.

Regression in c777bd6.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Fix Makefile export with Python 3
In Python 3, the map() function returns a map object, not a list object as in
Python 2. Ensure a list object is returned from format_flags() by wrapping
map() in list(). This is compatible with both Python 2 and 3.

@cmonr cmonr requested review from theotherjimmy and cmonr Oct 29, 2018

@cmonr cmonr added the needs: review label Oct 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 30, 2018

Thank you @lassebm for fix , we already assigned reviewers and will review it soon !

@cmonr

cmonr approved these changes Oct 31, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 31, 2018

Build : SUCCESS

Build number : 3523
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8577/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 1, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Nov 1, 2018

@theotherjimmy , care to take a look? this really should only take a moment (tiny change)

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 1, 2018

@NirSonnenschein Thanks for the ping. Feel free to merge this.

@cmonr cmonr merged commit 48bb1a5 into ARMmbed:master Nov 1, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10018 cycles (-321 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Nov 1, 2018

@lassebm lassebm deleted the lassebm:fix-makefile-export-with-python-3 branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment