New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxy fix on netsocket docs #8603

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
5 participants
@jamesbeyond
Contributor

jamesbeyond commented Oct 31, 2018

Description

This fix contains 2 fixes:

  • exclude vendor's EMAC driver from doxy
  • fixed missing NetworkInterface Class in doxy

Pull request type

-->
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cc @AnotherButler @SeppoTakalo

@jamesbeyond

This comment has been minimized.

Contributor

jamesbeyond commented Oct 31, 2018

Before exclude EMAC drivers

before

After exclude EMAC drivers

after

Before NetworkInterface missing

netif_before

After NetworkInterface missing fixed

netif_after

@0xc0170 0xc0170 requested a review from AnotherButler Oct 31, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 6, 2018

Note: This PR is now a part of a rollup PR (#8652).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr cmonr merged commit 60cc0c2 into ARMmbed:master Nov 7, 2018

11 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10246 cycles (+258 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment