New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and pinned version for requests #8616

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
5 participants
@cmonr
Contributor

cmonr commented Nov 1, 2018

Description

A CVE was made public about a possible vulnerability involving the requests python module.

Version has been updated to latest secure version, with pinning added to not auto increase past patch releases.

Testing

Tested in Linux using Py2 and Py3 pipenv environments by running pip install -r requirements.txt in each.

Windows testing ongoing.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@cmonr cmonr requested review from ARMmbed/mbed-os-maintainers Nov 1, 2018

@cmonr cmonr force-pushed the cmonr:update-requests-module branch from 70bb387 to 1f727e3 Nov 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 1, 2018

Rebased and re-tested.

@cmonr cmonr added needs: CI and removed needs: review labels Nov 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 1, 2018

Build : SUCCESS

Build number : 3527
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8616/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 8dbb13d into ARMmbed:master Nov 2, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10235 cycles (-162 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment