New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect xinetd service pattern and generate correct pattern (ONME-3733) #8645

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
7 participants
@mtomczykmobica
Contributor

mtomczykmobica commented Nov 5, 2018

Description

Task ONE-3733. Add support for xinetd chargen service. Modify pattern creation function to be compatible with xinetd chargen service.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@mtomczykmobica

This comment has been minimized.

Contributor

mtomczykmobica commented Nov 5, 2018

@SeppoTakalo please review.

@0xc0170 0xc0170 requested a review from SeppoTakalo Nov 5, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Nov 6, 2018

Looks good

@0xc0170

Please review astyle travis job

@0xc0170 0xc0170 added needs: work and removed needs: review labels Nov 6, 2018

@jeromecoutant

Tested OK with local ST server with XINETD service
and still OK with ARM server (echo.mbedcloudtesting.com)

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Nov 6, 2018

Note that ONME-3733 seems to be #7292
Maybe it's better to use github Id instead of ARM internal Id 😕
Thx @mtomczykmobica for the fix

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-3733 branch from 00b8fef to 11b650c Nov 6, 2018

@mtomczykmobica

This comment has been minimized.

Contributor

mtomczykmobica commented Nov 6, 2018

astyle fixed. @0xc0170 please review.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Nov 6, 2018

I can still see couple of things the Astyle changed:
https://travis-ci.org/ARMmbed/mbed-os/jobs/451318512

One is just whitespace at the end of line. Others are visible.

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-3733 branch from 11b650c to 655ab0f Nov 6, 2018

@mtomczykmobica

This comment has been minimized.

Contributor

mtomczykmobica commented Nov 6, 2018

FIxed.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Nov 6, 2018

@0xc0170

0xc0170 approved these changes Nov 6, 2018

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:ONME-3733 branch from 655ab0f to 5eabfab Nov 7, 2018

@cmonr

cmonr approved these changes Nov 7, 2018

Neat!

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Nov 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 8, 2018

Build : SUCCESS

Build number : 3575
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8645/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 8, 2018

@0xc0170 0xc0170 changed the title from ONME-3733 detect xinetd service pattern and generate correct pattern to Detect xinetd service pattern and generate correct pattern (ONME-3733) Nov 8, 2018

@0xc0170 0xc0170 merged commit 937d68f into ARMmbed:master Nov 8, 2018

16 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
travis-ci/astyle Passed, 544 files (-1 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9337 cycles (-688 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment