New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in the FVP platform where flash API page size was wrong #8692

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
4 participants
@jamesbeyond
Contributor

jamesbeyond commented Nov 9, 2018

Description

fix a bug in the FVP platform where flash API page size was wrong.

Was mistaken page size as block size.
This issue cause the Pelion Cloud Client SOTP initialization failed.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@jamesbeyond

This comment has been minimized.

Contributor

jamesbeyond commented Nov 9, 2018

Flash related test result attached

+---------------------+---------------+----------------------------------------------------------+----------------------------------------+--------+--------+--------+--------------------+
| target              | platform_name | test suite                                               | test case                              | passed | failed | result | elapsed_time (sec) |
+---------------------+---------------+----------------------------------------------------------+----------------------------------------+--------+--------+--------+--------------------+
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device | FlashSimBlockDevice functionality test | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - init                        | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program                     | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program across sectors      | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program errors              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - timing                      | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - clock and cache test           | 1      | 0      | OK     | 0.06               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - erase sector                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - init                           | 1      | 0      | OK     | 0.04               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - mapping alignment              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - program page                   | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device | FlashSimBlockDevice functionality test | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - init                        | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program                     | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program across sectors      | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program errors              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - timing                      | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - clock and cache test           | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - erase sector                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - init                           | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - mapping alignment              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - program page                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device | FlashSimBlockDevice functionality test | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - init                        | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program                     | 1      | 0      | OK     | 0.06               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program across sectors      | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program errors              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - timing                      | 1      | 0      | OK     | 0.02               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - clock and cache test           | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - erase sector                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - init                           | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - mapping alignment              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - program page                   | 1      | 0      | OK     | 0.0                |
+---------------------+---------------+----------------------------------------------------------+----------------------------------------+--------+--------+--------+--------------------+
@cmonr

cmonr approved these changes Nov 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 9, 2018

@jamesbeyond Why is string.h now needed as well?

@jamesbeyond

This comment has been minimized.

Contributor

jamesbeyond commented Nov 12, 2018

@cmonr, It is not compulsory, I just included them the suppress the compiler warning messages for the memset()/memcpy()

@cmonr cmonr added needs: CI and removed needs: review labels Nov 12, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 12, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 12, 2018

Build : SUCCESS

Build number : 3606
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8692/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 13, 2018

Note: This PR is now a part of a rollup PR (#8733).

In order to expidite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit f7ff09d into ARMmbed:master Nov 14, 2018

17 of 18 checks passed

ci-morph-test test completed
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 542 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9199 cycles (-1065 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Nov 14, 2018

@cmonr cmonr removed the rollup PR label Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment