New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: Use path names for ignored dirs #8697

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Nov 9, 2018

Description

Ignored directories are collected for the sake of exporters that use
a blacklist-style approach similar to these build tools. This ignore
list will include /filer/<gibberish> when exported from the online
Compiler. This patch fixes that behavoir.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Resources: Use path names for ignored dirs
### Description

Ignored directories are collected for the sake of exporters that use
a blacklist-style approach similar to these build tools. This ignore
list will include `/filer/<gibberish>` when exported from the online
Compiler. This patch fixes that behavoir.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change

@cmonr cmonr requested a review from ARMmbed/mbed-os-tools Nov 9, 2018

@cmonr

cmonr approved these changes Nov 14, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Nov 14, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3628
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8697/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 15, 2018

Export falures do not appear to be due to PR.
(Jenkins Nodes dropped)

Will restart when able.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Nov 15, 2018

/morph export-build

@0xc0170 0xc0170 added the rollup PR label Nov 15, 2018

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit b99fd40 into ARMmbed:master Nov 15, 2018

16 of 18 checks passed

ci-morph-exporter
Details
ci-morph-test test completed
Details
ci-morph-build build completed
Details
ci-morph-mbed2-build build completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 50 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9081 cycles (-121 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment