Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L3IP Interface Implementation #8739

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@tymoteuszblochmobica
Copy link
Contributor

commented Nov 14, 2018

Description

LWIP L3IP interface initial implementation

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@SeppoTakalo please review
@mikaleppanen please review
@kjbracey-arm please review
@mirelachirica please review
@AriParkkila please review

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Nov 14, 2018

@0xc0170

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

@tymoteuszblochmobica Please review Ci failures (travis)

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch 4 times, most recently to d512867 Nov 14, 2018

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2018

@0xc0170 Can be tested now.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

travis-ci/astyle — Passed, 66 files (+8 files)

@tymoteuszblochmobica Please fix these (I would recommend rebasing on top of the latest master, this would be an error in Travis) and we will run CI asap

@0xc0170
Copy link
Member

left a comment

Apply to all new files added here

@@ -0,0 +1,167 @@
/* mbed Microcontroller Library
* Copyright (c) 2016 ARM Limited

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Nov 16, 2018

Member

Add SPDX identifier, also fix the year (2018)

This comment has been minimized.

Copy link
@tymoteuszblochmobica

tymoteuszblochmobica Nov 20, 2018

Author Contributor

done

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch 7 times, most recently Nov 16, 2018

features/lwipstack/lwipopts.h Outdated
@@ -331,6 +331,8 @@
#define LWIP_ETHERNET 0
#endif // MBED_CONF_LWIP_ETHERNET_ENABLED

#define LWIP_L3IP 1

This comment has been minimized.

Copy link
@mikaleppanen

mikaleppanen Nov 20, 2018

Contributor

I think this needs similar configuration option as ethernet to mbed_lib.json. And should be disabled by default.

This comment has been minimized.

Copy link
@tymoteuszblochmobica

tymoteuszblochmobica Nov 20, 2018

Author Contributor

changed

@0xc0170 0xc0170 added needs: work and removed needs: review labels Nov 20, 2018

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch 2 times, most recently Nov 20, 2018

@0xc0170 0xc0170 requested review from AnotherButler and melwee01 Nov 21, 2018

@0xc0170

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

@AnotherButler @melwee01 Please review docs for the new functionality

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch to 703dea3 Nov 23, 2018

@0xc0170

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

@AnotherButler @melwee01 Please review docs for the new functionality

Please review. We will start tests now.

@SeppoTakalo @tymoteuszblochmobica 5.11 target or ?

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

Not 5.11 target.. can enter the master now, but will be functional only when first L3 driver published.
So probably 5.12

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch from 703dea3 Dec 4, 2018

@0xc0170

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

I started CI to check if this fails as previously did, meanwhile waiting for reviewers to complete their reviews

@melwee01

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

I'll take a look.

@melwee01
Copy link
Contributor

left a comment

Have looked at first header file, but will get to second one after lunch.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Have looked at first header file, but will get to second one after lunch.

Ok waiting with CI. First run failed due to EOF exception, will need restart anyway

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

@melwee01 Doing alright?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

@AnotherButler Please complete the docs review.

@AnotherButler
Copy link
Contributor

left a comment

Please make my requested changes and then feel free to merge

features/netsocket/cellular/cellular_driver_l3ip.h Outdated

/** Remove device from an IPV6 multicast group
*
* @param address An IPV6 multicast group address

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

Please do a search for "group address", and delete the extra space each time.

features/netsocket/cellular/cellular_driver_l3ip.h Outdated
virtual bool power_up();

/**
* Deinitializes the HW

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

Please spell out "hardware" each time for consistency.

features/netsocket/cellular/cellular_driver_l3ip.h Outdated
* That can not be called from an interrupt context.
*
* @param buf Packet to be send
* @return True if the packet was send successfully, False otherwise

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

was sent, false otherwise

features/netsocket/cellular/cellular_driver_l3ip.h Outdated
*
* That can not be called from an interrupt context.
*
* @param buf Packet to be send

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

to be sent

features/netsocket/cellular/cellular_driver_l3ip.h Outdated
/**
* Sends the packet over the link
*
* That can not be called from an interrupt context.

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

cannot

features/netsocket/L3IP.h Outdated
* That can not be called from an interrupt context.
*
* @param buf Packet to be send
* @return True if the packet was send successfully, False otherwise

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

was sent successfully, false otherwise

features/netsocket/L3IP.h Outdated
/**
* Sends the packet over the link
*
* That can not be called from an interrupt context.

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

cannot

features/netsocket/L3IP.h Outdated
typedef mbed::Callback<void (net_stack_mem_buf_t *buf)> l3ip_link_input_cb_t;

/**
* Callback to be register with l3ip interface and to be called for link status changes

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

Callback to be registered with L3IP interface

features/netsocket/L3IP.h Outdated
static L3IP &get_default_instance();

/**
* Callback to be register with l3ip interface and to be called for received packets

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

Callback to be registered with L3IP

features/netsocket/L3IP.h Outdated

/**
* This interface should be used to abstract low level access to networking hardware
* All operations receive a `void *` hw pointer which an l3ip device provides when

This comment has been minimized.

Copy link
@AnotherButler

AnotherButler Dec 14, 2018

Contributor

hardware pointer, which an L3IP device

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch 2 times, most recently to 4f34dd1 Dec 17, 2018

L3IP Interface Implementation
LWIP L3IP interface initial implementatioon

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:master branch from 4f34dd1 to fc88922 Dec 20, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Dec 20, 2018

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Dec 20, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 8
Build artifacts

@cmonr cmonr merged commit ac361d6 into ARMmbed:master Dec 20, 2018

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 0 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10327 cycles (+1167 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.