Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move socket-stats-enable config to socket-stats-enabled #9067

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
@kegilbert
Copy link
Contributor

commented Dec 12, 2018

Description

This conforms with the other stats config option names.

TODO:

  • Update Example
  • Update Docs

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@kegilbert kegilbert requested a review from deepikabhavnani Dec 12, 2018

@cmonr cmonr added the needs: review label Dec 12, 2018

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@kegilbert - Looks good to me, but I have a query: Documents get updated for patch version changes or minor as well?

If we leave it as _enable in document and merge this PR in master it will not match. I would not be much concerned about old feature as most of the times user get aware of the code and check it directly in master, but for new feature should we hold this consistency change for next minor?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@ARMmbed/mbed-docs Question about when updates happen

@iriark01

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

We don't build master publicly; the public doxygen is always from an official release branch.
We do build master for the test documentation, and that will be updated almost as soon as you merge.

@cmonr

cmonr approved these changes Dec 14, 2018

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

I'm fine with this, but from what I can tell, this would need to be pushed out to 5.12. Please correct me if this is wrong.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

Yes 5.12

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

@kegilbert I suspect that the example(s) would need to be updated before this could be tested?

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Dec 25, 2018

Correct @cmonr

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

@kegilbert What is the status here? Any upcoming updates here as this PR is still open

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

Apologies for the delay, I'll update the docs and examples for this.

@kegilbert

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

@cmonr cmonr removed the parked label Jan 17, 2019

@deepikabhavnani
Copy link
Contributor

left a comment

Good to go 👍

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 18, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

restarted ci

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 21, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

What's the status here? Two PRs are still opened.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

What's the status here? Two PRs are still opened

Other PR's can be merged after this is in. This is good to go to CI.

Query - Example PR is up - not in merged state. Should that be merged first for CI to start in this PR?
If I update the example first, other PR's in CI will fail for example.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

#9067 (comment)

The example needs to be updated first.

If this runs with the current example, the example build will fail because the config parameter changed.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

The example needs to be updated first

Example merged

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

CI started

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

#9906 (comment)

Now that the example has been updated, build will start to fail until this is merged into master.

CC @ARMmbed/mbed-os-maintainers

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 1, 2019

Test run: FAILED

Summary: 3 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC5
@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@kegilbert -

"./BUILD/K66F/IAR/.includes_980defce55bb8bfa1a450986b3159977.txt --preinclude=./BUILD/K66F/IAR/mbed_config.h --dependencies BUILD/K66F/IAR/mbed-os/features/netsocket/SocketStats.d -l BUILD/K66F/IAR/mbed-os/features/netsocket/SocketStats.s.txt -o BUILD/K66F/IAR/mbed-os/features/netsocket/SocketStats.o ./mbed-os/features/netsocket/SocketStats.cpp
[Error] SocketStats.cpp@28,35: [Pe135]: class "SocketStats" (declared at line 59 of "/builds/ws/mbed-os-ci_build-IAR8@10/mbed-os/features/netsocket/SocketStats.h") has no member "_mutex"
[Error] SocketStats.cpp@29,24: [Pe135]: class "SocketStats" (declared at line 59 of "/builds/ws/mbed-os-ci_build-IAR8@10/mbed-os/features/netsocket/SocketStats.h") has no member "_stats"
[Error] SocketStats.cpp@30,19: [Pe135]: class "SocketStats" (declared at line 59 of "
Move socket-stats-enable to socket-stats-enabled.
This conforms with the other stats config option names

@kegilbert kegilbert force-pushed the kegilbert:socket-stats-name-conform branch 2 times, most recently Mar 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

CI started

@kegilbert kegilbert force-pushed the kegilbert:socket-stats-name-conform branch to 194fa12 Mar 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 1, 2019

Test run: FAILED

Summary: 7 of 9 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARMC5
  • jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
  • jenkins-ci/mbed-os-ci_build-IAR8
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR8
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

Ignore #9067 (comment). This is from the last stopped job.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 1, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 5
Build artifacts

@cmonr cmonr merged commit c9192b9 into ARMmbed:master Mar 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9122 cycles (-209 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 1, 2019

@cmonr cmonr referenced this pull request Mar 5, 2019

Closed

Feature watchdog #9840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.