Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to error url to enhance error analytics #9188

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
8 participants
@SenRamakri
Copy link
Collaborator

commented Dec 21, 2018

Description

This change adds more info to the error URL in error-report to enable additional analytics in https://mbed.com/s/error. It adds following info to the error URL:
CPU id (if stats enabled)
Compiler used (if stats enabled)
Compiler version (if stats enabled)
MbedOS version (if stats enabled)
Target name

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@@ -108,11 +108,6 @@
"value": null
},

"error-decode-http-url-str": {

This comment has been minimized.

Copy link
@SenRamakri

SenRamakri Dec 21, 2018

Author Collaborator

I removed this config as its used only in one place. So I'm just hard-coding for now.

This comment has been minimized.

Copy link
@cmonr

cmonr Jan 3, 2019

Contributor

That's fine, but because this is a config removal, this change would cause it to be bumped to 5.12.

Will assume that is the intention for now, unless this change is reverted to remain.

@BlackstoneEngineering
Copy link
Contributor

left a comment

This makes sense to me and looks good. I approve

@@ -201,6 +201,8 @@ def get_symbols(self, for_asm=False):
if MBED_ORG_USER:
self.cxx_symbols.append('MBED_USERNAME=' + MBED_ORG_USER)

# Add target's name
self.cxx_symbols += ["TARGET_NAME=" + self.target.name]

This comment has been minimized.

Copy link
@cmonr

cmonr Jan 3, 2019

Contributor

Interesting. I thought this information would have already been available elsehwere.

This comment has been minimized.

Copy link
@cmonr

cmonr Jan 9, 2019

Contributor

@theotherjimmy @bridadan Making sure before I press the button. Is this symbol not already available in the build system?

This comment has been minimized.

Copy link
@bridadan

bridadan Jan 10, 2019

Contributor

Sorry a bit late to review this. To my knowledge this symbol wasn't already present. The only that was present were symbols like TARGET_<target name>.

@cmonr

cmonr approved these changes Jan 3, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Jan 3, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 4, 2019

tools/toolchains/__init__.py Outdated
@@ -191,7 +191,7 @@ def get_symbols(self, for_asm=False):
labels = self.get_labels()
self.cxx_symbols = ["TARGET_%s" % t for t in labels['TARGET']]
self.cxx_symbols.extend(["TOOLCHAIN_%s" % t for t in labels['TOOLCHAIN']])

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Jan 4, 2019

Member

this empty space should be removed (how come astyle did not catch that)

This comment has been minimized.

Copy link
@cmonr

cmonr Jan 4, 2019

Contributor

@0xc0170 Congrats on the new test case!

This comment has been minimized.

Copy link
@SenRamakri

SenRamakri Jan 4, 2019

Author Collaborator

Fixed now.

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Jan 4, 2019

@SenRamakri SenRamakri force-pushed the SenRamakri:sen_ErrorUrlEnhance branch to 3e6dafa Jan 4, 2019

Comment addressed

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: work labels Jan 4, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 7, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Jan 8, 2019

@0xc0170 0xc0170 requested a review from bulislaw Jan 8, 2019

@cmonr cmonr merged commit f8d7c31 into ARMmbed:master Jan 10, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 0 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10376 cycles (-3 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.