Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPONENT_SD tests update for small RAM targets #9236

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
8 participants
@jeromecoutant
Copy link
Contributor

jeromecoutant commented Jan 3, 2019

Description

DIRS and SEEK tests are FAIL for targets with small RAM.

Buffer size can now be specified for each target.
Default size is not changed with that patch.

It has been divided by 2 for some small RAM targets.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 3, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 3, 2019

@cmonr

cmonr approved these changes Jan 3, 2019

Copy link
Contributor

cmonr left a comment

LGTM

@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

jeromecoutant commented Jan 15, 2019

Any update ? :-)

@dannybenor

This comment has been minimized.

Copy link

dannybenor commented Jan 15, 2019

@theamirocohen can you review?

DIRS and SEEK SD tests update for small RAM targets
Test buffer size can now be specified for each target

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_SD_TEST branch to f3ba34a Jan 18, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

jeromecoutant commented Jan 18, 2019

@theamirocohen any update ?

Thx

@cmonr cmonr requested a review from theamirocohen Jan 18, 2019

@@ -9,20 +9,30 @@
"CMD_TIMEOUT": 10000,
"CMD0_IDLE_STATE_RETRIES": 5,
"INIT_FREQUENCY": 100000,
"CRC_ENABLED": 1
"CRC_ENABLED": 1,
"TEST_BUFFER": 8192
},
"target_overrides": {

This comment has been minimized.

@theamirocohen

theamirocohen Jan 20, 2019

Contributor

Hi, Why were these 4 boards removed?

This comment has been minimized.

@theamirocohen

theamirocohen Jan 24, 2019

Contributor

Hi, Why were these 4 boards removed?

@jeromecoutant

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 24, 2019

Author Contributor

??
There is no removed boards...

This comment has been minimized.

@theamirocohen

theamirocohen Jan 24, 2019

Contributor

Weird, I saw 4 boards that were removed, never mind.
Thanks

@dannybenor

This comment has been minimized.

Copy link

dannybenor commented Jan 20, 2019

@jeromecoutant without the addition of "components_add": ["SD"] in targets.json I think the tests will not be relevant

@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

jeromecoutant commented Jan 21, 2019

without the addition of "components_add": ["SD"] in targets.json I think the tests will not be relevant

Sure... But this patch is when we add this SD component...
Thx

@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

jeromecoutant commented Jan 24, 2019

@theamirocohen any update ?
Thx

@theamirocohen

This comment has been minimized.

Copy link
Contributor

theamirocohen commented Jan 24, 2019

LGTM

@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

jeromecoutant commented Jan 29, 2019

Could we start CI ?
Thx

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 29, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Jan 29, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 29, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

Marking for patch, but would like another @ARMmbed/mbed-os-maintainers to ack.

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 30, 2019

@0xc0170 0xc0170 merged commit 1031e2d into ARMmbed:master Jan 30, 2019

23 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10158 cycles (-333 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_SD_TEST branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.