Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRAWAN: volatile bool -> atomic_flag #9245

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented Jan 3, 2019

Description

Now we have a proper atomic flag API, use it rather than a volatile cheat.

More in my "eliminate volatile" quest.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 3, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:lorawan_atomic_flag branch Jan 3, 2019

@0xc0170

0xc0170 approved these changes Jan 3, 2019

@hasnainvirk
Copy link
Contributor

left a comment

Nice one.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 3, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@cmonr cmonr added needs: work and removed needs: CI labels Jan 3, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

@kjbracey-arm Please take a look at the unit tests. They were not happy...

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:lorawan_atomic_flag branch Jan 4, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Tests hopefully cleared.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jan 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 14, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Looks like unittest failure does not propagate results to artifacts, will report this as an issue

For the errors, still reports undefined references

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Note, created internal ticket MBEDOSTEST-427 for unittests being in artifacts if fail

LoRAWAN: volatile bool -> atomic_flag
Now we have a proper atomic flag API, use it rather than a volatile
cheat.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:lorawan_atomic_flag branch to 6f757a5 Jan 14, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Try again...

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 14, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

Test restarted (CI script failure)

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 15, 2019

@0xc0170 0xc0170 merged commit 51a8c39 into ARMmbed:master Jan 16, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10244 cycles (+226 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

hasnainvirk added a commit to hasnainvirk/mbed-os that referenced this pull request Feb 5, 2019

_rx_ready flag is now atomic since ARMmbed#9245
_rx_ready boolean is not used anymore. We set/unset it using core util
atomic flag set test.

AnttiKauppila added a commit to AnttiKauppila/mbed-os that referenced this pull request May 8, 2019

_rx_ready flag is now atomic since ARMmbed#9245
_rx_ready boolean is not used anymore. We set/unset it using core util
atomic flag set test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.