Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep: error flags fix #9277

Merged
merged 3 commits into from Feb 20, 2019

Conversation

@deepikabhavnani
Copy link
Contributor

commented Jan 7, 2019

Description

All the debug calls in sleep manager for sleep tracing should be changed to mbed_error_printf since most sleep API's and calls are interrupt and thread safe. PR #9260

Issue was seen only with debug profile and was not captured in develop profile because MBED_TRAP_ERRORS_ENABLED flag was not set in develop profile. Fixed here.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[X] Breaking change

Reviewers

@kjbracey-arm @theotherjimmy

Release notes

This change adds the MBED_TRAP_ERRORS_ENABLED flag to the develop profile. It traps on RTX errors and invalid operations in ISR context enabled in the develop profile. These errors were silent in the develop profile.
This change might result in an increase of the final binary size.

@ciarmcom ciarmcom requested review from kjbracey-arm, theotherjimmy and ARMmbed/mbed-os-maintainers Jan 7, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

@cmonr

cmonr approved these changes Jan 8, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

@ARMmbed/mbed-os-maintainers - Can we test this PR in CI (based on availability) to see the impact of newly added flags

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

@deepikabhavnani Will look at doing that tomorrow. We still have a queue of PRs in CI for 5.11.2 will be generated tonight.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

5.11.2 is still not completed (currently one more fix incoming most probably), I'll set this to needs: CI to run it through CI

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 15, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

5.11.2 is still not completed (currently one more fix incoming most probably), I'll set this to needs: CI to run it through CI

Shall I still rebase to pick new Travis changes? Rebase done, can test as per CI availability

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:flags_fixes branch Jan 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Jan 17, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

@theotherjimmy @kjbracey-arm Any thoughts?

@deepikabhavnani I just had a thought. This is probably going to add more debug symbols and increase binary size for debug builds, correct?

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

@cmonr - Yes some more debug messages

#if defined(MBED_TRAP_ERRORS_ENABLED) && MBED_TRAP_ERRORS_ENABLED

MBED_ERROR(MBED_MAKE_ERROR(MBED_MODULE_PLATFORM, MBED_ERROR_INVALID_OPERATION),

#if defined(MBED_TRAP_ERRORS_ENABLED) && MBED_TRAP_ERRORS_ENABLED

increase binary size for debug builds

CI runs debug builds but I don't see any size increase

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

CI runs debug builds but I don't see any size increase

Oh. That was a welcome surprise.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

Add flag "-DMBED_TRAP_ERRORS_ENABLED=1" to develop profile as well

Why is this being added to develop profile? It was not initially clear. Can you add it to the commit msg?

How is this breaking - by adding a new macro to the develop profile?

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

CI has passed, but does this still needs and additional review. @kjbracey-arm @theotherjimmy could you please take a look

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

Ready to merge?

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

hi @deepikabhavnani , Breaking changes now need a release notes section in the description. see example here:#9568

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

hi @deepikabhavnani , Breaking changes now need a release notes section in the description. see example here:#9568

Done. Can be reviewed by @ARMmbed/mbed-docs

@0xc0170 0xc0170 requested a review from bulislaw Feb 11, 2019

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

The final approval waiting for @bulislaw but as he is OoO this week, @donatieng can you review instead please?

@0xc0170 0xc0170 requested review from donatieng and SenRamakri Feb 11, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

Ready to merge?

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Ready to merge?

While waiting for final approval, running CI now as it was a week ago.

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Feb 20, 2019

@donatieng
Copy link
Member

left a comment

Looks good to me!

@cmonr cmonr added ready for merge and removed needs: review labels Feb 20, 2019

@cmonr cmonr merged commit 2910ed5 into ARMmbed:master Feb 20, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9231 cycles (+68 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.