Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen fixes for IP networking area #9328

Merged
merged 25 commits into from Jan 22, 2019

Conversation

@SeppoTakalo
Copy link
Contributor

SeppoTakalo commented Jan 10, 2019

Description

Doxygen fixes and clarifications for IP networking area.
We have also combined some updates from Ari regarding Cellular area.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@KariHaapalehto @AriParkkila @kjbracey-arm

@SeppoTakalo SeppoTakalo force-pushed the SeppoTakalo:ip-core-doxygen branch Jan 10, 2019

@ciarmcom ciarmcom requested review from AriParkkila , KariHaapalehto , kjbracey-arm and ARMmbed/mbed-os-maintainers Jan 10, 2019

@ciarmcom

This comment has been minimized.

@KariHaapalehto KariHaapalehto force-pushed the SeppoTakalo:ip-core-doxygen branch Jan 10, 2019

Show resolved Hide resolved features/netsocket/DTLSSocket.h Outdated
Show resolved Hide resolved features/netsocket/EthInterface.h Outdated
Show resolved Hide resolved features/netsocket/Socket.h Outdated
Show resolved Hide resolved features/netsocket/Socket.h Outdated
Show resolved Hide resolved features/netsocket/Socket.h Outdated
Show resolved Hide resolved features/netsocket/TLSSocket.h Outdated
Show resolved Hide resolved features/netsocket/TLSSocketWrapper.h Outdated
Show resolved Hide resolved features/netsocket/WiFiInterface.h Outdated
Show resolved Hide resolved features/netsocket/WiFiInterface.h Outdated

@cmonr cmonr added needs: work and removed needs: review labels Jan 10, 2019

@melwee01

This comment has been minimized.

Copy link
Contributor

melwee01 commented Jan 11, 2019

I'm working on these right now, so you don't need to worry about applying my comments unless there are content, not editing, issues.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 11, 2019

Can you review travis failures, some are pointing to the undefined parameters or astyle reporting changes in the license alignment or similar?

Show resolved Hide resolved features/netsocket/Socket.h Outdated
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor Author

SeppoTakalo commented Jan 15, 2019

Needs work label can be removed. This is reviewed and review findings are fixed.
Can be merged in.

No API changes, so can also be published in patch release.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Jan 15, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 15, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@SeppoTakalo SeppoTakalo force-pushed the SeppoTakalo:ip-core-doxygen branch to 6b8b108 Jan 21, 2019

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor Author

SeppoTakalo commented Jan 21, 2019

Rebased and fixed the missing copyright header.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jan 21, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 21, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Jan 22, 2019

dynamic-memory-usage restarted

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 22, 2019

@0xc0170 0xc0170 merged commit 31579fe into ARMmbed:master Jan 22, 2019

22 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10148 cycles (+1139 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.