Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #9092 from mprse/stack_unification_sec_try" #9349

Closed
wants to merge 1 commit into from

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Jan 11, 2019

Description

This reverts commit 2454b25, reversing
changes made to 12980f4.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

…sec_try"

This reverts commit 2454b25, reversing
changes made to 12980f4.
@cmonr cmonr requested review from mprse and a team January 11, 2019 05:51
@cmonr
Copy link
Contributor Author

cmonr commented Jan 11, 2019

Starting CI to confirm PR was part of the problem, and to give the other @ARMmbed/mbed-os-maintainers a path forward since it's pretty late over here.

@cmonr
Copy link
Contributor Author

cmonr commented Jan 11, 2019

CI started

@mprse
Copy link
Contributor

mprse commented Jan 11, 2019

What problems were caused by #9092?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

I believe a new target came in about the same time. #9232 this could be it, we need to find failures in the latest CI runs, will check

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

@mprse
Copy link
Contributor

mprse commented Jan 11, 2019

I believe a new target came in about the same time. #9232 this could be it, we need to find failures in the latest CI runs, will check

I also noticed that new target has been added just before #9092. If this is the case I can create a PR with updated linker scripts for the added target.

@mprse
Copy link
Contributor

mprse commented Jan 11, 2019

Found it, http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/9203/3/build-ARM/FAIL/

Great! I'll create a PR with fix for these two targets.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

I aborted the test, build passed means this would fix it but we rather fix it properly soon

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

Aborted the job (CI machine restart needed), anyway there is already a fix

@cmonr
Copy link
Contributor Author

cmonr commented Jan 11, 2019

@mprse Whoops! Should've provided more direct links to the failures.
Glad you were able to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants