Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed_boot_arm_std.c: remove redundant compiler check #9352

Merged
merged 2 commits into from Jan 15, 2019

Conversation

Projects
None yet
4 participants
@mprse
Copy link
Member

commented Jan 11, 2019

Description

Fix for ARMC6 compiler.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

I could reproduce this error locally: "rtos\TARGET_CORTEX\TOOLCHAIN_ARM_STD\mbed_boot_arm_std.c:64:26: error: use of undeclared identifier 'ISR_STACK_START'" using ARMC6

Once the patch applied, I was able to build the test.

K64F::ARMC6::TESTS-MBEDMICRO-RTOS-MBED-MALLOC

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

The fix goes for 5.12 as it's dependent on the changes for 5.12

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Thinking about this more. As we noticed this failure for ARMC6. It should have been caught in CI for v8, shouldn't it ?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

I've checked one nuvoton v8 target, it defines ISR_STACK_SIZE thus was not executing failing code as in this fix. Thus was not discovered in the CI (ARMC6 was built there).

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Aborted, needs to wait for #9350

mprse added some commits Jan 11, 2019

mbed_boot_arm_std.c: remove redundant compiler check
Check is not needed since this file is exclusive for ARM compiler.
It causes problems on ARMC6.

@mprse mprse force-pushed the mprse:armc6_fix branch to 8cc4234 Jan 11, 2019

@mprse

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

Added also similar fix for GCC.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

@0xc0170 this passed CI, does it need another review or can it be moved to "ready"

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 14, 2019

@0xc0170 0xc0170 merged commit aff2bee into ARMmbed:master Jan 15, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9192 cycles (-146 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.