Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Warn with ARMC6 and not v8m" #9398

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
6 participants
@kjbracey-arm
Copy link
Contributor

commented Jan 16, 2019

Description

A requested change from the toolchain guys, who are working on getting ARMC6 support online - the the misleading message "ARMC6 does not support ARM architecture v7" is winding them up.

Not clear we need any message at this point, at least on master. Maybe we will need something more specific about targets later, once we can pin down restrictions.

This reverts commit 3f68411.

Marked it as a "docs update", as it doesn't change the build result, just what the build prints. That probably doesn't make any sense.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@theotherjimmy
Copy link
Contributor

left a comment

Thanks. Looks good to me.

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

I think they would also quite like this backported to a 5.11.y so they can get a clean-looking build prior to official Mbed OS 5.12 release. I leave that open to debate - maybe with sufficient disclaimers elsewhere...

@0xc0170 0xc0170 requested a review from bulislaw Jan 16, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

I think they would also quite like this backported to a 5.11.y so they can get a clean-looking build prior to official Mbed OS 5.12 release. I leave that open to debate - maybe with sufficient disclaimers elsewhere...

Fine with me

cc @bulislaw

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

If we can rebase, will fix travis

@cmonr cmonr added the needs: CI label Jan 16, 2019

@cmonr cmonr force-pushed the kjbracey-arm:no_armc6_warn branch Jan 17, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Marked for 5.12 for now. If ARMc6 support slips, past that RC, we'll need to re-enable the message.

I'm sure you've informed them that the main reason around the message is to help set user expectations as to what compilers are actively supported.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

SIGH

travis-ci/doxy-spellcheck failure is caused by something slipping in whilst the PR that enabled the job was making it's way through testing.

mbed-os master is broken (https://travis-ci.org/ARMmbed/mbed-os/jobs/480700843) and needs a fix to progress this PR. Hold tight.

@cmonr cmonr force-pushed the kjbracey-arm:no_armc6_warn branch to d17d43b Jan 17, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 19, 2019

@0xc0170 0xc0170 merged commit 2a7a326 into ARMmbed:master Jan 21, 2019

22 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9246 cycles (-776 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:no_armc6_warn branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.