Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: adds and implements a --custom-targets command line switch #9401

Merged
merged 5 commits into from Jan 21, 2019

Conversation

Projects
None yet
5 participants
@loverdeg-ep
Copy link
Contributor

commented Jan 16, 2019

Description

Per #6581

adds and implements a --custom-targets command line switch

If --custom-targets switch is provided, it will be used for custom_targets.json directory instead of the --source switch.

Was looking for a test of tools/options.py's extract_mcu's to update but didn't find.
Point me in the right direction if I missed it.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@loverdeg-ep loverdeg-ep changed the title Adds adds and implements a --custom-targets command line switch tools: adds and implements a --custom-targets command line switch Jan 16, 2019

@ciarmcom ciarmcom requested review from theotherjimmy and ARMmbed/mbed-os-maintainers Jan 16, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

@theotherjimmy
Copy link
Contributor

left a comment

Could you move the addition of --custom-targets into get_default_options_parser? Then you can remove it from get_config.py, make.py and test.py.

@theotherjimmy

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

Was looking for a test of tools/options.py's extract_mcu's to update but didn't find.

I don't think we have a test for that. I'll accept any tests, and I can merge it with other tests if needed or if I find other tests later.

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

Could you move the addition of --custom-targets into get_default_options_parser? Then you can remove it from get_config.py, make.py and test.py.

Was hoping you'd say that!

@loverdeg-ep loverdeg-ep force-pushed the loverdeg-ep:custom-targets-option branch Jan 17, 2019

@theotherjimmy
Copy link
Contributor

left a comment

1 more duplicated addition of --custom-targets

Show resolved Hide resolved tools/build.py Outdated
@theotherjimmy
Copy link
Contributor

left a comment

Previously clicked the wrong radial button. Meant to request changes.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

Can you also rebase, once you add commits to address review, thanks (will fix spellcheck failure)

@loverdeg-ep loverdeg-ep force-pushed the loverdeg-ep:custom-targets-option branch to bb5ea80 Jan 17, 2019

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

@theotherjimmy did I miss anything? any last requests?

@theotherjimmy
Copy link
Contributor

left a comment

@loverdeg-ep You missed nothing.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 21, 2019

@0xc0170 0xc0170 merged commit 091fe2b into ARMmbed:master Jan 21, 2019

22 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9072 cycles (-950 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@loverdeg-ep loverdeg-ep deleted the loverdeg-ep:custom-targets-option branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.