Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IAR Armv8M changes #9431

Merged
merged 6 commits into from Feb 4, 2019

Conversation

Projects
None yet
9 participants
@deepikabhavnani
Copy link
Contributor

deepikabhavnani commented Jan 18, 2019

Description

Update IAR flags for Armv8M devices.

Cortex-M23 / Cortex-M33 CPU settings for baseline and mainline
profile (with optional floating and dsp options) updated.

Dependent on #9480

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 18, 2019

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 18, 2019

Show resolved Hide resolved tools/toolchains/iar.py Outdated
Show resolved Hide resolved tools/toolchains/iar.py Outdated
Show resolved Hide resolved tools/toolchains/iar.py Outdated

@cmonr cmonr added needs: work and removed needs: review labels Jan 22, 2019

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:iar_armv8m_changes branch to 7292acf Jan 23, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Jan 23, 2019

@kjbracey-arm @theotherjimmy - Please review

@theotherjimmy
Copy link
Contributor

theotherjimmy left a comment

Looks good supposing that we're leaving the core-reworking to another PR.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Jan 23, 2019

supposing that we're leaving the core-reworking to another PR.

Yes core reworking will in another PR (by tools team :-) )

@cyliangtw
Copy link
Contributor

cyliangtw left a comment

In iar_definitions.json, M2351 part should be:
"M2351KIAAEES": {
"OGChipSelectEditMenu": "M2351 series\tNuvoton M2351 series"
}

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:iar_armv8m_changes branch 3 times, most recently from 3d2420c Jan 24, 2019

deepikabhavnani added some commits Jan 7, 2019

Update IAR flags for Armv8M devices.
Cortex-M23 / Cortex-M33 CPU settings for baseline and mainline
profile (with optional floating and dsp options) updated.
Correct the floating+dsp options for Cortex-M processors
As per the IAR Development guide, below options for CPU are valid

1. Cortex-M33
2. Cortex-M33.no_dsp (core without integer DSP extension)
3. Cortex-M33.fp (floating-point unit with support for single precision)
4. Cortex-M33.no_se (core without support for TrustZone)
5. Cortex-M4
6. Cortex-M4F
7. Cortex-M7
8. Cortex-M7.fp.dp (floating-point unit with support for double precision)
9. Cortex-M7.fp.sp (floating-point unit with support for single precision)

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:iar_armv8m_changes branch to 6097095 Jan 31, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Jan 31, 2019

Rebased to pull in dependent PR changes

@bridadan
Copy link
Contributor

bridadan left a comment

Nice work! One non-blocking style nit pick.

Show resolved Hide resolved tools/toolchains/iar.py Outdated
Add missing space - coding style nit
Co-Authored-By: deepikabhavnani <deepika.bhavnani@arm.com>
@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 2, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Feb 2, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 2, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 0ae6a04 into ARMmbed:master Feb 4, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9455 cycles (-1068 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.