Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPU_USED to be set based on HW FPU support + Squash commits #9437

Merged
merged 3 commits into from Jan 24, 2019

Conversation

Projects
None yet
@deepikabhavnani
Copy link
Contributor

commented Jan 19, 2019

Description

New Commit - __FPU_USED to be set based on HW FPU support
__FPU_USED flag is not set by compiler or tools, instead it should be
enabled based on HW FPU flags as done in "cmsis/TARGET_CORTEX_M/core_armv8mml.h"

Additional changes - Revert old CMSIS/RTX commits for pre-processor flags to create one single commit for importer script entry

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

deepikabhavnani and others added some commits Jan 18, 2019

Reverted 4 CMSIS/RTX commits for Assembly files
1. Revert "CMSIS/RTX: __FPU_USED to be set based on HW FPU support"
This reverts commit b4f5bed7e75c21927c954a50d40422b81a1de5a0.

2. Revert "CMSIS/RTX: Update Armv8M IAR 8.x assembly files - add END"
This reverts commit b228cd9.

3. Revert "CMSIS/RTX: Pre-processor defines used for assembly"
This reverts commit 287121f.

4. Revert "CMSIS/RTX: Patch RTX so irq_cm4f.s files work with no FPU targets"
This reverts commit cc2e051.
CMSIS/RTX: Pre-processor defines used for assembly
CMSIS repo does not support pre-processor defines, hence multiple assembly
files are added for secure/non-secure and floating point tools.
Mbed OS tools support assembly file pre-processing, but the build system
does not support multiple assembly files for each target, hence updating
the assembly files.

1. Patch RTX so irq_cm4f.S files work with no FPU targets
2. Patch RTX so irq_armv8mml.S files to work with and without FPU
2. Patch RTX so irq_armv8mml.S and irq_armv8mbl.S files to work with secure and
   non-secure builds

@deepikabhavnani deepikabhavnani changed the title Preprocess asm FPU_USED to be set based on HW FPU support + Squash commits Jan 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 19, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 19, 2019

@bridadan
Copy link
Contributor

left a comment

I think tools got tagged because of the json changes. I trust you checked those commits 👍

@cmonr cmonr added needs: CI and removed needs: review labels Jan 23, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 23, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Restarted CI

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 23, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 23, 2019

@cmonr cmonr merged commit 7bdc280 into ARMmbed:master Jan 24, 2019

23 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9089 cycles (+80 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 24, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2019

This is sitting on top of #8887 scheduled for 5.12

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:preprocess_asm branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.