Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated PinMap for each QSPI data line #9438

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
10 participants
@c1728p9
Copy link
Contributor

commented Jan 19, 2019

Description

Split PinMap_QSPI_DATA into PinMap_QSPI_DATA0 - PinMap_QSPI_DATA3. This allows pins to be selected more accurately and may be used in the future for QSPI testing.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@@ -312,14 +312,25 @@ MBED_WEAK const PinMap PinMap_CAN_TD[] = {

//*** QUADSPI ***

MBED_WEAK const PinMap PinMap_QSPI_DATA[] = {
{PA_1, QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF9_QSPI)}, // QUADSPI_BK1_IO3
{PB_6, QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF10_QSPI)}, // QUADSPI_BK1_NCS

This comment has been minimized.

Copy link
@c1728p9

c1728p9 Jan 19, 2019

Author Contributor

@jeromecoutant This isn't a data pin. Was QSPI always broken on this port?

This comment has been minimized.

Copy link
@jeromecoutant

jeromecoutant Jan 21, 2019

Contributor

Yes, no QUADSPI_BK1_IO2 pin for STM32F446RE...

@jeromecoutant
Copy link
Contributor

left a comment

Hi @c1728p9

Everything seems correct!

There was an issue with NCS pins which were added in the data list pins,
and you have corrected this! 👍

I have updated tools/targets/STM32_gen_PeripheralPins.py
I will push it after this PR merge.

@@ -312,14 +312,25 @@ MBED_WEAK const PinMap PinMap_CAN_TD[] = {

//*** QUADSPI ***

MBED_WEAK const PinMap PinMap_QSPI_DATA[] = {
{PA_1, QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF9_QSPI)}, // QUADSPI_BK1_IO3
{PB_6, QSPI_1, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF10_QSPI)}, // QUADSPI_BK1_NCS

This comment has been minimized.

Copy link
@jeromecoutant

jeromecoutant Jan 21, 2019

Contributor

Yes, no QUADSPI_BK1_IO2 pin for STM32F446RE...

@c1728p9 c1728p9 referenced this pull request Jan 22, 2019

Merged

Pinmap extensions #9449

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

CI started

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Jan 22, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 22, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2019

Show resolved Hide resolved ...reescale/TARGET_MCUXpresso_MCUS/TARGET_K82F/TARGET_FRDM/PeripheralPins.c Outdated
Show resolved Hide resolved ...eescale/TARGET_MCUXpresso_MCUS/TARGET_KL82Z/TARGET_FRDM/PeripheralPins.c Outdated
Use dedicated PinMap for each QSPI data line
Split PinMap_QSPI_DATA into PinMap_QSPI_DATA0 - PinMap_QSPI_DATA3.
This allows pins to be selected more accurately.

@c1728p9 c1728p9 force-pushed the c1728p9:qspi_update branch to 82b131a Jan 22, 2019

@SenRamakri
Copy link
Collaborator

left a comment

LGTM

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2019

CI started.

@cmonr cmonr added needs: CI and removed needs: work labels Jan 22, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 22, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
@mbed-ci

This comment has been minimized.

Copy link

commented Jan 22, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Not sure why jenkins-ci/mbed-os-ci_build-ARMC6 is being ping'd.
@ARMmbed/mbed-os-test-team has been ping'd for assistance.

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Restarted CI

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 23, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

@OPpuolitaival

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Now ARMC6 seems to pass

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

[x] Functionality change

@c1728p9 This was selected for 5.12 based on PR type. If this is not the case, let us know

@0xc0170 0xc0170 merged commit a6509cf into ARMmbed:master Jan 23, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9171 cycles (+8 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

jeromecoutant added a commit to jeromecoutant/mbed that referenced this pull request Jan 24, 2019

STM32_gen_PeripheralPins.py v1.5
Use dedicated PinMap for each QSPI data line ARMmbed#9438

adbridge added a commit that referenced this pull request Feb 8, 2019

STM32_gen_PeripheralPins.py v1.5
Use dedicated PinMap for each QSPI data line #9438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.