Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: calls MBED_ERROR if modem's watchdog reset gets triggered #9456

Merged

Conversation

Projects
None yet
8 participants
@VeijoPesonen
Copy link
Contributor

commented Jan 22, 2019

Description

ESP8266: calls MBED_ERROR if modem's watchdog reset gets triggered. Addresses the issue #9425

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm
@michalpasztamobica

@michalpasztamobica
Copy link
Contributor

left a comment

I checked that there is also MBED_ERROR_CODE_TIMEOUT, but I guess you made a better choice. I personally don't understand the difference between the two and TIMEOUT isn't used anywhere, so let's stick with ETIME.

@ciarmcom ciarmcom requested review from kjbracey-arm, michalpasztamobica, SeppoTakalo and ARMmbed/mbed-os-maintainers Jan 22, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

While we finalize reviews, CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 29, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

jenkins-ci/greentea-test restarted

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

Waiting on either @kjbracey-arm or @michalpasztamobica to ok before merging.

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

@michalpasztamobica please re-review.

@cmonr cmonr added ready for merge and removed needs: review labels Jan 31, 2019

@cmonr cmonr merged commit b506b03 into ARMmbed:master Jan 31, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+24 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9067 cycles (-96 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.