Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwipstack: mem-size set to the to minimal working size with DTLS #9471

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
7 participants
@mtomczykmobica
Copy link
Contributor

mtomczykmobica commented Jan 23, 2019

… DTLS

Description

Modiefie mem-size parameter to minimal size that work with DTLS

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 0xc0170 changed the title Modiefie mem-size parameter to minimal size that work with… lwipstack: mem-size set to the to minimal working size Jan 23, 2019

@0xc0170 0xc0170 changed the title lwipstack: mem-size set to the to minimal working size lwipstack: mem-size set to the to minimal working size with DTLS Jan 23, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 23, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 23, 2019

@mtomczykmobica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Jan 24, 2019

Did you test these values also with TLSSocket?

@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

mtomczykmobica commented Jan 24, 2019

Yes, tested with TLS too. (--tc DTLS,DTLS_NONBLOCK,TLSSOCKET_HANDSHAKE,TLSSOCKET_ECHOTEST,TCPSOCKET_ECHOTEST)

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Jan 24, 2019

Good.

@cmonr cmonr added needs: CI and removed needs: review labels Jan 30, 2019

@cmonr

cmonr approved these changes Jan 30, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

@mtomczykmobica Curious. Why the large min-size difference between families?

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Jan 31, 2019

Because some Ethernet drivers allocate large ring buffers from LwIP stack.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 695179b into ARMmbed:master Jan 31, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9181 cycles (-131 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.