Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: treats reset-ready-message as OOB #9473

Merged
merged 6 commits into from Feb 15, 2019

Conversation

Projects
None yet
9 participants
@VeijoPesonen
Copy link
Contributor

commented Jan 23, 2019

Description

Makes possible to detect if modem gets reset by handling the reset-ready-message as OOB.

Fixes the network status update callback to not report a state change if a state change hasn't really occurred.

Prevent's running reset twice in a row if reset pin is connected to a known pin.

Fixes UART HW flow control enabling sequence - adds also mutex.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@michalpasztamobica
@kjbracey-arm

Show resolved Hide resolved components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Outdated

@ciarmcom ciarmcom requested review from kjbracey-arm, michalpasztamobica, SeppoTakalo and ARMmbed/mbed-os-maintainers Jan 23, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:feature-esp8266_reset_handling branch Jan 24, 2019

@cmonr

cmonr approved these changes Jan 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Jan 29, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 30, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

Restarted CI job: jenkins-ci/mbed-os-ci_dynamic-memory-usage

The wifi test failed, but it's not clear why.

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:feature-esp8266_reset_handling branch Jan 30, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@cmonr Rebased.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 31, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Restarted dynamic usage, but still can you check the artifacts to confirm the failure not related?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Need to admit that the test results doesn't tell me much

[1548944538.40][HTST][INF] host test detected: default_auto
[1548944548.45][CONN][INF] found KV pair in stream: {{max_heap_usage;720}}, queued...
[1548944548.45][CONN][INF] found KV pair in stream: {{reserved_heap;183360}}, queued...
[1548944548.45][HTST][ERR] orphan event in main phase: {{max_heap_usage;720}}, timestamp=1548944548.451403
[1548944548.45][HTST][ERR] orphan event in main phase: {{reserved_heap;183360}}, timestamp=1548944548.451410
[1548944548.55][CONN][INF] found KV pair in stream: {{__thread_info;"0x020001738",1160,4096}}, queued...
[1548944548.55][CONN][INF] found KV pair in stream: {{__thread_info;"0x020001888",80,512}}, queued...
[1548944548.55][HTST][ERR] orphan event in main phase: {{__thread_info;"0x020001738",1160,4096}}, timestamp=1548944548.551406
[1548944548.55][CONN][INF] found KV pair in stream: {{__thread_info;"0x0200008ac",224,2048}}, queued...
[1548944548.55][HTST][ERR] orphan event in main phase: {{__thread_info;"0x020001888",80,512}}, timestamp=1548944548.551413
[1548944548.55][HTST][ERR] orphan event in main phase: {{__thread_info;"0x0200008ac",224,2048}}, timestamp=1548944548.551416
[1548944548.65][CONN][INF] found KV pair in stream: {{__thread_info;"0x020001844",104,768}}, queued...
[1548944548.65][CONN][INF] found KV pair in stream: {{end;failure}}, queued...
[1548944548.65][CONN][INF] found KV pair in stream: {{__exit;0}}, queued...
[1548944548.65][HTST][ERR] orphan event in main phase: {{__thread_info;"0x020001844",104,768}}, timestamp=1548944548.652407
[1548944548.65][HTST][INF] __exit(0)
[1548944548.65][HTST][INF] __notify_complete(False)
[1548944548.65][HTST][INF] __exit_event_queue received
[1548944548.65][HTST][INF] test suite run finished after 10.35 sec...
[1548944548.65][CONN][INF] received special event '__host_test_finished' value='True', finishing
[1548944548.65][urllib3.connectionpool]Starting new HTTP connection (1): ronja.mbedcloudtesting.com:80
[1548944548.87][urllib3.connectionpool]http://ronja.mbedcloudtesting.com:80 "PUT /resource/0311000040214e45003e1018c89200559e11000097969900/disconnect HTTP/1.1" 200 87
[1548944548.88][urllib3.connectionpool]Starting new HTTP connection (1): ronja.mbedcloudtesting.com:80
[1548944552.15][urllib3.connectionpool]http://ronja.mbedcloudtesting.com:80 "PUT /resource/0311000040214e45003e1018c89200559e11000097969900/release HTTP/1.1" 200 87
[1548944552.15][HTST][INF] CONN exited with code: 0
[1548944552.15][HTST][INF] Some events in queue
[1548944552.15][HTST][INF] stopped consuming events
[1548944552.15][HTST][INF] host test result() call skipped, received: False
[1548944552.15][HTST][INF] calling blocking teardown()
[1548944552.15][HTST][INF] teardown() finished
[1548944552.15][HTST][INF] {{result;failure}}
mbedgt: retry mbedhtrun 1/1
mbedgt: ['mbedhtrun', '-m', 'K66F', '-p', 'DUMMY:9600', '-f', u'"BUILD/dynamic/K66F/GCC_ARM/wifi/wifi.bin"', '--grm', 'raas_client:ronja.mbedcloudtesting.com:80', '-C', '4', '--sync', '5', '--tag-filters', 'MEMORY', '-P', '600'] failed after 1 count
mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'FAIL'
mbedgt: test case summary event not found
	no test case report present, assuming test suite to be a single test case!
	test suite: wifi
	test case: wifi
mbedgt: test on hardware with target id: DUMMY
mbedgt: test suite 'wifi' ............................................................................ FAIL in 41.72 sec
	test case: 'wifi' ............................................................................ FAIL in 41.72 sec
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@ARMmbed/mbed-os-test-team Can you help out with this one? Not sure why jenkins-ci/dynamic-memory-usage has repeatedly failed.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@VeijoPesonen to unblock this, can you talk to @timurh01 ?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

@0xc0170 I'll run the test manually to see what is wrong.

@cmonr cmonr added needs: work and removed needs: CI labels Feb 1, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Any update @VeijoPesonen ?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@VeijoPesonen ARMmbed/mbed-os-benchmarks#24 was just merged. It should now be in use within CI.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

CI job restarted: jenkins-ci/dynamic-memory-usage

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

components/wifi/esp8266-driver/ESP8266Interface.h

@VeijoPesonen Please rebase and we start CI

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:feature-esp8266_reset_handling branch to cbbe2ff Feb 15, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@0xc0170 rebase done.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

CI started

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

Something different this time:
The command "W: Failed to fetch http://repo.mongodb.org/apt/ubuntu/dists/trusty/mongodb-org/3.4/Release.gpg The following signatures were invalid: KEYEXPIRED 1515625755" failed 3 times.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Travis restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

This appears to be sitting on top of some 5.12 changes.
Release label updated.

@cmonr cmonr merged commit 7dbe541 into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/build-ARMC6 Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/cloud-client-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/exporter Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/greentea-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/mbed2-build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/mbed2-build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/mbed2-build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9473/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10455 cycles (+1091 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:feature-esp8266_reset_handling branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.