Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashIAP Block device: Assert if default constructor is used without setting config parameters #9475

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
8 participants
@davidsaada
Copy link
Contributor

davidsaada commented Jan 23, 2019

Description

FlashIAP block device's constructor has two parameters - base address and size (of the block device). Their default values are taken from the configuration, making it function as a default constructor. This PR produces an error if default constructor is used with unchanged config values (which are illegal).
Resolves #9468.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@tommikas

@ciarmcom ciarmcom requested review from tommikas and ARMmbed/mbed-os-maintainers Jan 23, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 23, 2019

@davidsaada, thank you for your changes.
@tommikas @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@tommikas
Copy link
Contributor

tommikas left a comment

👍

@dannybenor
Copy link

dannybenor left a comment

We did not find a way to fail in compilation, but improved the runtime error

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Jan 30, 2019

@cmonr

cmonr approved these changes Jan 30, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 31, 2019

@cmonr cmonr merged commit 39d4628 into ARMmbed:master Jan 31, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10257 cycles (+146 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 31, 2019

@bulislaw

This comment has been minimized.

Copy link
Member

bulislaw commented Feb 1, 2019

Was the fact that this use case is illegal documented in last release? In any case we need to mention it in release notes that now it'll fail and need to be fixed.

@ARMmbed/mbed-os-maintainers

@davidsaada davidsaada deleted the davidsaada:david_flashiap_no_default branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.