Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous Serial API fixes and refactoring #9476

Merged
merged 3 commits into from Mar 28, 2019

Commits on Feb 12, 2019

  1. Asynchronous Serial API fixes and refactoring, part 1

    1. As RX and TX flows are separate on Serial device, read and write
       functionalities should be completely separate, including any deep
       sleep locking etc.
    2. User may want to use asynchronous API without a callback (especially
       for write operations), for example in a command-response scheme
       end of write operation is usually meaningless. The intuitive
       method is to submit NULL pointer for a callback. For this reason
       depending on the _callback field in determining whether the
       operation is in progress seems to be uncertain, so introduced
       additional flags for this purpose.
    lrusinowicz committed Feb 12, 2019
    Copy the full SHA
    6d64809 View commit details
    Browse the repository at this point in the history
  2. Asynchronous Serial API fixes and refactoring, part 2

    Aborting of asynchronous operation is necessarily hazardous, as
    operation can end in interrupt anywhere from the point of decision
    until it is actually aborted down the abort_...() method.
    Proper deep sleep unlocking requires then use of the critical
    section and should be contained completely within API implementation.
    lrusinowicz committed Feb 12, 2019
    Copy the full SHA
    cbb84d8 View commit details
    Browse the repository at this point in the history
  3. Asynchronous Serial API fixes and refactoring, part 3

    Updated API documentation to better explain API operation and to explicitly
    point out that any event ends the operation.
    lrusinowicz committed Feb 12, 2019
    Copy the full SHA
    8586528 View commit details
    Browse the repository at this point in the history