Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage components #9478

Merged
merged 2 commits into from Jan 31, 2019

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Copy link
Contributor

deepikabhavnani commented Jan 23, 2019

Description

  1. Move common util folder for tests inside TESTS directory
  2. Config folder not needed for json file

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 23, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 23, 2019

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@davidsaada
Copy link
Contributor

davidsaada left a comment

Looks good and makes much sense. 👍

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Jan 30, 2019

@cmonr

cmonr approved these changes Jan 30, 2019

@cmonr cmonr added needs: work and removed needs: review labels Jan 30, 2019

deepikabhavnani added some commits Jan 23, 2019

Moved `mbed_lib.json` outside config folder
This is to have consistency across all storage components
Moved util (common test folder) inside the TESTS directory
Util was common test folder, which was kept outside as we had
no mechanism to have common files for various tests in tools.
Now same can be achieved by having COMMON folder inside tests
directory

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:refactor_sd branch to 2952735 Jan 30, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Jan 30, 2019

Rebased to resolve conflicts

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 31, 2019

@cmonr cmonr merged commit ffc52e6 into ARMmbed:master Jan 31, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9949 cycles (-162 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 31, 2019

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:refactor_sd branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.