Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BG96 netsocket tests #9514

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@mirelachirica
Copy link
Contributor

mirelachirica commented Jan 28, 2019

Description

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Jan 28, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 28, 2019

Show resolved Hide resolved features/cellular/framework/AT/AT_CellularStack.cpp Outdated

@mirelachirica mirelachirica force-pushed the mirelachirica:bg96_netsocket_tests branch Jan 28, 2019

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

mirelachirica commented Jan 29, 2019

Note: this PR should not be merged before feature-cellular-refactor branch is merged to master.

@mirelachirica mirelachirica force-pushed the mirelachirica:bg96_netsocket_tests branch Jan 29, 2019

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

mirelachirica commented Jan 29, 2019

Fixed the astyle failures.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 29, 2019

@mirelachirica #9514 (comment) Was this PR suppose to point to the feature branch instead of master?

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

mirelachirica commented Jan 30, 2019

@mirelachirica #9514 (comment) Was this PR suppose to point to the feature branch instead of master?

No. But on the other hand I dont want to cause any conflicts to the feature branch rebasing or merging. I would prefer to keep this pointing to master and on hold, until feature branch is merged. Will be easy to rebase this from master then. Is it ok?

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

@mirelachirica From a technical perspective, it isn't, and could require a lot of rebasing to keep this current with master.

@ARMmbed/mbed-os-maintainers try to keep the number of open PRs low (it's a constant challenge), and try to limit the number of PRs sitting in idle. Would closing and reopening when appropriate also work?

@mirelachirica mirelachirica force-pushed the mirelachirica:bg96_netsocket_tests branch to 28b4e28 Feb 8, 2019

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

mirelachirica commented Feb 8, 2019

rebased

@cmonr

cmonr approved these changes Feb 11, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: review labels Feb 11, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1bbb76d into ARMmbed:master Feb 12, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9165 cycles (-754 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.