Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: reduces SIGIO signaled to the upper layers #9520

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
7 participants
@VeijoPesonen
Copy link
Contributor

commented Jan 28, 2019

Description

Throttle event generation by applying a checking for already pending event.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm
@michalpasztamobica

@ciarmcom ciarmcom requested review from kjbracey-arm, michalpasztamobica, SeppoTakalo and ARMmbed/mbed-os-maintainers Jan 28, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@SeppoTakalo please re-review. Made the guarding variables atomic based on Kevin's request.

Show resolved Hide resolved components/wifi/esp8266-driver/ESP8266Interface.cpp Outdated
Show resolved Hide resolved components/wifi/esp8266-driver/ESP8266Interface.cpp Outdated

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:bugfix-esp8266_reduce_sigio branch Jan 29, 2019

@cmonr

cmonr approved these changes Jan 29, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Jan 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:bugfix-esp8266_reduce_sigio branch to 53c2879 Jan 30, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@SeppoTakalo , @0xc0170 rebased.

@0xc0170 0xc0170 added needs: CI and removed ready for merge labels Jan 30, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr removed the needs: CI label Jan 31, 2019

@0xc0170 0xc0170 merged commit f1bf5db into ARMmbed:master Feb 1, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10195 cycles (+84 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 1, 2019

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:bugfix-esp8266_reduce_sigio branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.