Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 fixes and Travis CI enablement #9521

Merged
merged 10 commits into from Jan 30, 2019

Conversation

Projects
None yet
6 participants
@cmonr
Copy link
Contributor

cmonr commented Jan 28, 2019

Description

Came across some issues when setting up a testing env for Windows Python build issues (https://travis-ci.org/cmonr/mbed-os/builds/485516791), so fixed them as I went along.

This PR only contains the Py3 fixes along with finally enabling Py3 tests in Travis CI.

A Travis CI refactor will followup once this is brought in.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@cmonr cmonr added the needs: review label Jan 28, 2019

@cmonr cmonr requested review from ARMmbed/mbed-os-maintainers Jan 28, 2019

@@ -1204,7 +1204,8 @@ def validate_config(self):
min = int(str(min), 0) if min is not None else None
max = int(str(max), 0) if max is not None else None

if (value < min or (value > max if max is not None else False)):
if ((value < min if min is not None else False) or

This comment has been minimized.

@theotherjimmy

theotherjimmy Jan 28, 2019

Contributor

Could this be written:

Suggested change
if ((value < min if min is not None else False) or
if ((min is not None and value < min) or
@@ -1204,7 +1204,8 @@ def validate_config(self):
min = int(str(min), 0) if min is not None else None
max = int(str(max), 0) if max is not None else None

if (value < min or (value > max if max is not None else False)):
if ((value < min if min is not None else False) or
(value > max if max is not None else False)):

This comment has been minimized.

@theotherjimmy

theotherjimmy Jan 28, 2019

Contributor
Suggested change
(value > max if max is not None else False)):
(max is not None and value > max)):

cmonr added some commits Jan 28, 2019

Enable xenail dist for only Py37 job
Other jobs will follow with other PR
Updated spm test runner wish short import variant
Co-Authored-By: cmonr <Cruz.Monrreal@arm.com>
@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Jan 29, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 29, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 30, 2019

@0xc0170 0xc0170 merged commit 93f0a09 into ARMmbed:master Jan 30, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9345 cycles (-388 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@bridadan

This comment has been minimized.

Copy link
Contributor

bridadan commented Feb 14, 2019

This PR seems to have broken building with Python 3 for the 5.11.4 release. This is causing errors in the Mbed CLI CI: https://circleci.com/gh/ARMmbed/mbed-cli/1319?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Feb 15, 2019

@bridadan I'd be curious if #9673 manages to fix the issue, since the error string looks similar to other issues that 9673 fixed.

@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Feb 15, 2019

(I'm working on adding a compile step after the pytests to make sure this kind of thing is hard to reproduce, but I'll be damned if I'm going to do it while relying on apt-get)

@bridadan

This comment has been minimized.

Copy link
Contributor

bridadan commented Feb 19, 2019

The fix in #9673 fixed it locally for me, and the CI test will be very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.