Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix missing scan timeout for 4.2 controllers using new API #9549

Merged
merged 3 commits into from Jan 31, 2019

Conversation

Projects
None yet
5 participants
@paul-szczepanek-arm
Copy link
Member

paul-szczepanek-arm commented Jan 30, 2019

Description

Controllers that don't support extended advertising don't create an event on advertising timeout and need extra support to behave correctly with the new API. This fix creates the event on on the user side making the behaviour consistent for older controllers.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@paul-szczepanek-arm paul-szczepanek-arm requested a review from pan- Jan 30, 2019

_pal_gap.scan_enable(false, false);
set_random_address_rotation(false);
}

if (!_scan_enabled) {

This comment has been minimized.

@paul-szczepanek-arm

paul-szczepanek-arm Jan 30, 2019

Author Member

this should be checked first

@pan-

pan- approved these changes Jan 30, 2019

@cmonr

cmonr approved these changes Jan 30, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 31, 2019

@0xc0170 0xc0170 merged commit 94baadf into ARMmbed:master Jan 31, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10109 cycles (-2 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.