Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify general blockdevice tests to run all storage components #9551

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
6 participants
@theamirocohen
Copy link
Contributor

theamirocohen commented Jan 30, 2019

Description

All tests will run for each storage component available on device excapt for test_get_type_functionality that will run once on the default blockdevice.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

@dannybenor
Copy link

dannybenor left a comment

Good work, let's enhance for all available blockdevices

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 30, 2019

@theamirocohen, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 30, 2019

@cmonr

cmonr approved these changes Jan 30, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Jan 30, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr cmonr added needs: work and removed needs: CI labels Jan 31, 2019

Modify general blockdevice tests to run all storage components
All tests will run for each storage component available on device excapt for test_get_type_functionality that will run once on the default blockdevice.

@theamirocohen theamirocohen force-pushed the theamirocohen:fix_gen_test_for_flashiap branch to f1f60bf Jan 31, 2019

@theamirocohen theamirocohen changed the title Expand general blockdevice tests to enforce FLASHIAP check Modify general blockdevice tests to run all storage components Jan 31, 2019

@theamirocohen

This comment has been minimized.

Copy link
Contributor Author

theamirocohen commented Jan 31, 2019

Good work, let's enhance for all available blockdevices

The tests were modified

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

#9551 (comment)

Ah, I thought that change was going to come later.

@cmonr cmonr added needs: review and removed needs: work labels Jan 31, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

@dannybenor Mind re-reviewing?

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 31, 2019

@0xc0170 0xc0170 merged commit a0c4646 into ARMmbed:master Feb 1, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10081 cycles (-362 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.