Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wio 3G: Modified sequence of module startup. #9554

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
6 participants
@ytsuboi
Copy link
Contributor

commented Jan 30, 2019

Description

Fix for issue #9450

Pull request type

[ x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ytsuboi ytsuboi changed the title Modified sequence of module startup. [Wio 3G] Modified sequence of module startup. Jan 30, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 30, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

@ytsuboi, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Member

left a comment

Add details to the commit msg, how is this fixing the issue (what modificaftions are needed and why)

@AriParkkila
Copy link
Contributor

left a comment

Please wait until feature-cellular-refactor is merged to master.

Show resolved Hide resolved ...s/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96_CellularPower.cpp Outdated
@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

@AriParkkila Do you have any target date for the merge?

@AriParkkila

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

@ytsuboi it should be merged quite soon, but I don't know actual schedule.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@ytsuboi We will coordinate and let you know.

@AriParkkila As this is simple change, can we include this in refactor ?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

feature-cellular-refactor has since been merged.

Please rebase when possible.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@ytsuboi Do you need any assistance to update this PR?

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_3g-9450 branch Feb 18, 2019

@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

still need testing on my side.

@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@0xc0170 It works!

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 18, 2019

@0xc0170
Copy link
Member

left a comment

One last question - how is this fixing the issue? Can you describe it in the commit message pls - I can see edits in the startup file, but what they are addressing and fixing? Reference issue +1 but some details should be present here

@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Fixed issue by adding turning off the modem power once at startup, so that modem is sure to be the initial state.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Fixed issue by adding turning off the modem power once at startup, so that modem is sure to be the initial state.

Please add this to the commit message.

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_3g-9450 branch Feb 18, 2019

@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@0xc0170 added.

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_WIO_3G/onboard_modem_api.c Outdated
}

void onboard_modem_deinit()
{
// wio3g_mdm_powerOff();
onboard_modem_power_down();

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Feb 19, 2019

Contributor

Should this be gpio_init_out_ex(&gpio, M_POWR, 1);, that's vice versa from onboard_modem_init()?

This comment has been minimized.

Copy link
@cmonr

This comment has been minimized.

Copy link
@ytsuboi

ytsuboi Feb 20, 2019

Author Contributor

I agree with you. That makes more sense. I will change this.

This comment has been minimized.

Copy link
@ytsuboi

ytsuboi Feb 20, 2019

Author Contributor

@AriParkkila changed.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

CI started whilst waiting for final discussion to settle

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@ytsuboi Once updated, please let us know

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 20, 2019

@0xc0170 0xc0170 changed the title [Wio 3G] Modified sequence of module startup. Wio 3G: Modified sequence of module startup. Feb 20, 2019

[Wio 3G] Fix onboard modem initialization
Fix for issue #9450 by adding turning off the modem power at startup, so that modem is sure to be in the initial state.
Fix for wrong filename and classname.

// WIP

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_3g-9450 branch to c41f1c7 Feb 20, 2019

@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

@0xc0170 updated

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 20, 2019

@0xc0170 0xc0170 merged commit 39c8374 into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10517 cycles (+1367 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.