Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wio BG96: Modified sequence of module startup #9555

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
6 participants
@ytsuboi
Copy link
Contributor

commented Jan 30, 2019

Description

Fix the issue #9450

Pull request type

[ x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 30, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

@ytsuboi, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Member

left a comment

How is this fixing the issue referenced? I see lot of changes but commit msg only "modified startup seq"

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 30, 2019

@AriParkkila
Copy link
Contributor

left a comment

Please remove QUECTEL_BG96_CellularPower.cpp/h files completely. The implementation was moved to ONBOARD_QUECTEL_BG96.cpp.

The onboard_modem implementation is fine.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@AriParkkila we should have mentioned - cellular refactor landed recently to master and it caused conflicts.

@ytsuboi Ari will help you to bring this up to date to the current master and possibly if this is really needed for 5.11.x release. Let us know, as fixes for current 5.11.x release might require manual additions for 5.11 branch

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

feature-cellular-refactor has since been merged.

Please rebase when possible.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@ytsuboi Do you need any assistance to update this PR?

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_bg96-9450 branch Feb 18, 2019

[Wio BG96] Fix onboard modem initialization
Fix for issue #9450 by adding turning off the modem power at startup, so that modem is sure to be in the initial state.

@ytsuboi ytsuboi force-pushed the SeeedJP:hal-wio_bg96-9450 branch to 89bb25e Feb 18, 2019

@ytsuboi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@0xc0170 Done. Thanks for your kind assistance.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 18, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@AriParkkila Please review

@AriParkkila
Copy link
Contributor

left a comment

::onboard_modem_init() is probably not needed at constructor, otherwise this is fine.

@@ -25,6 +25,7 @@ using namespace mbed;

ONBOARD_QUECTEL_BG96::ONBOARD_QUECTEL_BG96(FileHandle *fh) : QUECTEL_BG96(fh)
{
::onboard_modem_init();

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Feb 19, 2019

Contributor

I don't think this is needed, because CellularContext::connect() at first tries to power on modem by calling hard_power_on which calls this ::onboard_modem_init();.

This comment has been minimized.

Copy link
@ytsuboi

ytsuboi Feb 19, 2019

Author Contributor

We definitely need this to fix the issue #9450

@cmonr cmonr added needs: CI and removed needs: review labels Feb 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

CI started.

Reviews appear to be complete

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 20, 2019

@0xc0170 0xc0170 changed the title [Wio BG96] Modified sequence of module startup. Wio BG96: Modified sequence of module startup Feb 20, 2019

@0xc0170 0xc0170 merged commit 3f46c82 into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9170 cycles (+16 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.