Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an ip4- and ip6-compliant site to test TLS certificate error reporting #9572

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
6 participants
@michalpasztamobica
Copy link
Contributor

michalpasztamobica commented Jan 31, 2019

Description

So far we used os.mbed.com to test that an incorrect (but valid) TLS certificate fails when trying to establish a connection. os.mbed.com is not ipv6-compliant, so it has to be changed for some other website that will also be able to reject our certificate. Google.com is a safe choice, it rejects our certificate and is very stable.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 31, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 31, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 31, 2019

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

michalpasztamobica commented Jan 31, 2019

Travis failure is not related to the changes.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

@michalpasztamobica I'll be so glad once apt-get usage is removed from Travis...

If that happens again, feel free to restart the Travis CI job. apt-get issues tend to be intermitent.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

CI started by @0xc0170

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 31, 2019

@0xc0170 0xc0170 merged commit 3d4582b into ARMmbed:master Feb 1, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10479 cycles (+36 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 1, 2019

@michalpasztamobica michalpasztamobica deleted the michalpasztamobica:greentea_tls_ipv6_compliant_website branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.