Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo no_dsp - nodsp #9606

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
8 participants
@deepikabhavnani
Copy link
Contributor

deepikabhavnani commented Feb 4, 2019

Description

Correct typo - no dsp option for armclang is nodsp (without underscore)

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Correct typo no_dsp - nodsp
armclang - nodsp
armlink - no_dsp

diff --git a/tools/t

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 4, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 4, 2019

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@@ -404,8 +404,8 @@ def __init__(self, target, *args, **kwargs):
"Cortex-M4F": "cortex-m4",
"Cortex-M7F": "cortex-m7",
"Cortex-M7FD": "cortex-m7",
"Cortex-M33": "cortex-m33+no_dsp+no_fp",
"Cortex-M33F": "cortex-m33+no_dsp",
"Cortex-M33": "cortex-m33+nodsp",

This comment has been minimized.

@NirSonnenschein

NirSonnenschein Feb 5, 2019

Contributor

no_fp was removed as well as the fix to no_dsp, is this intentional?

This comment has been minimized.

@deepikabhavnani

deepikabhavnani Feb 5, 2019

Author Contributor

Yes nofp as well gave error when used with clang. No_fp is valid with armlink

This comment has been minimized.

@NirSonnenschein

NirSonnenschein Feb 5, 2019

Contributor

Just wanted to make sure as this wasn't mentioned in the commit comment or PR description.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 5, 2019

CI started

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Feb 5, 2019

Hi
Could you check in GCC as well ?

[DEBUG] Output: arm-none-eabi-gcc: error: unrecognized argument in option '-mcpu=cortex-m33+no_dsp'

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 5, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Feb 5, 2019

~~Isn’t dsp option nodsp - c472005#diff-f8a1211bf0ff7089cff6fc47859a1734R78~~~

@jeromecoutant - My bad, same mistake was done while creation of lookup tables. febbeff#diff-f8a1211bf0ff7089cff6fc47859a1734. Since this PR has passed CI will add it to another PR.

@mikisch81

This comment has been minimized.

Copy link
Contributor

mikisch81 commented Feb 5, 2019

@ARMmbed/mbed-os-maintainers ready for merge?

@0xc0170 0xc0170 merged commit 4ce6ed0 into ARMmbed:master Feb 5, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10221 cycles (+1007 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 5, 2019

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:core_arch_v8m branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.