Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K64/ARM: Update to 2-region model for HEAP and Stack Memory #9613

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
6 participants
@mprse
Copy link
Member

mprse commented Feb 5, 2019

Description

This is patch for Issue #9523 (K64F only).

Tested the solution on:

  • non-rtos version for blinky,
  • tests-mbedmicro-rtos-mbed-heap_and_stack and tests-mbed_hal-stack_size_unification tests (for rtos builds).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@deepikabhavnani please review.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

deepikabhavnani commented Feb 5, 2019

Thanks for the PR, looks good to me

@@ -0,0 +1,74 @@
/* mbed Microcontroller Library - stackheap
* Copyright (C) 2019-2019 ARM Limited. All rights reserved.
*

This comment has been minimized.

@0xc0170

0xc0170 Feb 5, 2019

Member

this should contain SPDX identifier, apache 2.0

@mprse mprse force-pushed the mprse:stack_heap_fix_k64f_only branch to 292f1a1 Feb 5, 2019

@JanneKiiskila

This comment has been minimized.

Copy link
Contributor

JanneKiiskila commented Feb 6, 2019

How about K66F? Would something similar be needed there?

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

deepikabhavnani commented Feb 6, 2019

How about K66F? Would something similar be needed there?

Solution for other targets is here: #9571

@0xc0170

0xc0170 approved these changes Feb 7, 2019

@0xc0170 0xc0170 requested a review from deepikabhavnani Feb 7, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

Shall this be closed or can go in as it is and #9571 will go separately?

@JanneKiiskila

This comment has been minimized.

Copy link
Contributor

JanneKiiskila commented Feb 11, 2019

@ARMmbed/mbed-os-maintainers - please target to next patch release.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

While waiting for @deepikabhavnani approval, running CI

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

deepikabhavnani commented Feb 11, 2019

This is needed for Bootloader - patch release. 9571 will be minor release, will rebase 9571 after this is merged, to revert the K64F change and use generic one

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 11, 2019

@0xc0170 0xc0170 merged commit fd5a6af into ARMmbed:master Feb 11, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+12 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10249 cycles (-219 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.