Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cortex-m33-S gcc compilation error #9614

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
8 participants
@mikisch81
Copy link
Contributor

mikisch81 commented Feb 5, 2019

Description

Fixes cortex-m33-S gcc compilation error due to a bug in gcc.py (Issue #9608).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@deepikabhavnani @ARMmbed/mbed-os-tools

Fix cortex-m33-S compile error
Compilation error was due to due to bug in gcc.py
@deepikabhavnani
Copy link
Contributor

deepikabhavnani left a comment

Thanks for fixing

@0xc0170

0xc0170 approved these changes Feb 5, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 5, 2019

starting CI

@bridadan
Copy link
Contributor

bridadan left a comment

Good catch!

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 5, 2019

Test run: FAILED

Summary: 2 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@alekla01

This comment has been minimized.

Copy link
Contributor

alekla01 commented Feb 5, 2019

restarted ci

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 5, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 6, 2019

@ARMmbed/mbed-os-maintainers Can it be merged?

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 6, 2019

Hi @mikisch81,
please write a proper description for the PR.

@mikisch81 mikisch81 changed the title Fix cortex-m33-S compile error Fix cortex-m33-S gcc compilation error Feb 6, 2019

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 6, 2019

Hi @mikisch81,
please write a proper description for the PR.

Isn't the link to the issue is enough?

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 7, 2019

@NirSonnenschein Updated the description.

@0xc0170 0xc0170 merged commit 9bda449 into ARMmbed:master Feb 7, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9172 cycles (-1296 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.