Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the dsp flag from no_dsp to nodsp #9619

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
@deepikabhavnani
Copy link
Contributor

deepikabhavnani commented Feb 5, 2019

Description

Correct the dsp flag from no_dsp to nodsp.
support for nodsp flag is added by GCC compiler version 7 and above.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

CC @jeromecoutant

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 5, 2019

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@jeromecoutant
Copy link
Contributor

jeromecoutant left a comment

I don't know why, but I still got issue:

[DEBUG] Output: arm-none-eabi-gcc: error: unrecognized argument in option '-mcpu=cortex-m33+nodsp'

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

kjbracey-arm commented Feb 6, 2019

Which GCC version? (I can imagine quite a new version of GCC may be needed here).

@mikisch81

This comment has been minimized.

Copy link
Contributor

mikisch81 commented Feb 6, 2019

@jeromecoutant
For me (Musca_a1 target, also cortes-m33) it works fine with 6-2017-q2-update gcc version.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 6, 2019

starting CI

@mikisch81

This comment has been minimized.

Copy link
Contributor

mikisch81 commented Feb 6, 2019

@jeromecoutant
For me (Musca_a1 target, also cortes-m33) it works fine with 6-2017-q2-update gcc version.

But Musca compiles wiithout floating point, so I guess its a different story..

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 6, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

alekla01 commented Feb 6, 2019

restarted greentea

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Feb 6, 2019

I don't know why, but I still got issue:
[DEBUG] Output: arm-none-eabi-gcc: error: unrecognized argument in option '-mcpu=cortex-m33+nodsp'

GCC toolchain version on my setup is: 7 2018-q2-update

I can see failure for no_dsp option but nodsp is accepted.


"C:\Program Files (x86)\GNU Tools ARM Embedded\7 2018-q2-update\bin\arm-none-eabi-gcc"  -mcpu=cortex-m33+no_dsp  -o main.o main.cpp
arm-none-eabi-gcc: error: unrecognized argument in option '-mcpu=cortex-m33+no_dsp'
arm-none-eabi-gcc: note: valid arguments to '-mcpu=' are: arm1020e arm1020t arm1022e arm1026ej-s arm10e arm10tdmi arm1136j-s arm1136jf-s arm1156t2-s arm1156t2f-s arm1176jz-s arm1176jzf-s arm2 arm250 arm3 arm6 arm60 arm600 arm610 arm620 arm7 arm70 arm700 arm700i arm710 arm7100 arm710c arm710t arm720 arm720t arm740t arm7500 arm7500fe arm7d arm7di arm7dm arm7dmi arm7m arm7tdmi arm7tdmi-s arm8 arm810 arm9 arm920 arm920t arm922t arm926ej-s arm940t arm946e-s arm966e-s arm968e-s arm9e arm9tdmi cortex-a12 cortex-a15 cortex-a15.cortex-a7 cortex-a17 cortex-a17.cortex-a7 cortex-a32 cortex-a35 cortex-a5 cortex-a53 cortex-a57 cortex-a57.cortex-a53 cortex-a7 cortex-a72 cortex-a72.cortex-a53 cortex-a73 cortex-a73.cortex-a35 cortex-a73.cortex-a53 cortex-a8 cortex-a9 cortex-m0 cortex-m0.small-multiply cortex-m0plus cortex-m0plus.small-multiply cortex-m1 cortex-m1.small-multiply cortex-m23 cortex-m3 **cortex-m33 cortex-m33+nodsp** cortex-m4 cortex-m7 cortex-r4 cortex-r4f cortex-r5 cortex-r52 cortex-r7 cortex-r8 ep9312 exynos-m1 fa526 fa606te fa626 fa626te fa726te fmp626 generic-armv7-a iwmmxt iwmmxt2 marvell-pj4 mpcore mpcorenovfp native strongarm strongarm110 strongarm1100 strongarm1110 xgene1 xscale; did you mean 'cortex-m33+nodsp'?
arm-none-eabi-gcc: error: main.cpp: No such file or directory
arm-none-eabi-gcc: fatal error: no input files
compilation terminated.

Please scroll the list and you can see following valid options for cortex-m33: cortex-m33 cortex-m33+nodsp


"C:\Program Files (x86)\GNU Tools ARM Embedded\7 2018-q2-update\bin\arm-none-eabi-gcc"  -mcpu=cortex-m33+nodsp  -o main.o main.cpp
c:/program files (x86)/gnu tools arm embedded/7 2018-q2-update/bin/../lib/gcc/arm-none-eabi/7.3.1/../../../../arm-none-eabi/lib/thumb/v8-m.main\libc.a(lib_a-exit.o): In function `exit':
exit.c:(.text.exit+0x16): undefined reference to `_exit'
@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Feb 6, 2019

DSP option is not available with 6 2017-q2-update version

"C:\Program Files (x86)\GNU Tools ARM Embedded\6 2017-q2-update\bin\arm-none-eabi-gcc" -mcpu=cortex-m33+nodsp  -o main.o main.cpp
arm-none-eabi-gcc: error: unrecognized argument in option '-mcpu=cortex-m33+nodsp'
arm-none-eabi-gcc: note: valid arguments to '-mcpu=' are: arm1020e arm1020t arm1022e arm1026ej-s arm10e arm10tdmi arm1136j-s arm1136jf-s arm1156t2-s arm1156t2f-s arm1176jz-s arm1176jzf-s arm2 arm250 arm3 arm6 arm60 arm600 arm610 arm620 arm7 arm70 arm700 arm700i arm710 arm7100 arm710c arm710t arm720 arm720t arm740t arm7500 arm7500fe arm7d arm7di arm7dm arm7dmi arm7m arm7tdmi arm7tdmi-s arm8 arm810 arm9 arm920 arm920t arm922t arm926ej-s arm940t arm946e-s arm966e-s arm968e-s arm9e arm9tdmi cortex-a12 cortex-a15 cortex-a15.cortex-a7 cortex-a17 cortex-a17.cortex-a7 cortex-a32 cortex-a35 cortex-a5 cortex-a53 cortex-a57 cortex-a57.cortex-a53 cortex-a7 cortex-a72 cortex-a72.cortex-a53 cortex-a8 cortex-a9 cortex-m0 cortex-m0.small-multiply cortex-m0plus cortex-m0plus.small-multiply cortex-m1 cortex-m1.small-multiply cortex-m23 cortex-m3 cortex-m33 cortex-m4 cortex-m7 cortex-r4 cortex-r4f cortex-r5 cortex-r7 cortex-r8 ep9312 exynos-m1 fa526 fa606te fa626 fa626te fa726te fmp626 generic-armv7-a iwmmxt iwmmxt2 marvell-pj4 mpcore mpcorenovfp native qdf24xx strongarm strongarm110 strongarm1100 strongarm1110 xgene1 xscale
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 7, 2019

DSP option is not available with 6 2017-q2-update version

Means we can't accept this without updating GCC version?

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Feb 7, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Feb 7, 2019

@0xc0170

0xc0170 approved these changes Feb 7, 2019

Copy link
Member

0xc0170 left a comment

Understanding this is not supported case with current GCC, these new cores will require newer GCC.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 7, 2019

Correct the dsp flag from no_dsp to nodsp

@deepikabhavnani Might be updated this to explain the version needed for this fix to be valid? Not everyone is aware of version implications

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Feb 7, 2019

@deepikabhavnani By updated Martin is referring to the description. It needs more detail to cover the versions what this fix is compatible with and those it isn't. Plus any other implications.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

deepikabhavnani commented Feb 7, 2019

Officially only Arm compiler is supported for Armv8m devices. Docs and support for Armv8m will be updated when GCC compiler is updated in Mbed OS.

Unlike other targets, mandatory toolchain for Armv8m on master is ARMc6. Post 5.12 release IAR 8.x will also be added for Armv8m

@NirSonnenschein NirSonnenschein merged commit 5ef9499 into ARMmbed:master Feb 7, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9245 cycles (-511 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:typo_correct branch Mar 1, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

jeromecoutant commented Mar 15, 2019

Hi
Back to the question of GCC version!

I could see in last doc page : https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/tools/tools_intro.md
that

  • requested IAR version becomes 8.32
  • requested ARM version becomes 6.11

but no update for GCC whereas it seems that 7.x is needed for v8m ?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Mar 15, 2019

GCC ARM update should be easier to do compare to the last 2 updates, should come. No update for 5.12.

cc @SenRamakri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.