Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TESTS/netsocket/ for cellular testing #9645

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
9 participants
@AriParkkila
Copy link
Contributor

commented Feb 8, 2019

Description

Change TESTS/netsocket/ for cellular testing:

  • Test loops reduced and timings increased for cellular network slowness
  • Network disconnect added at the end of DNS test suite
  • Socket send/receive asynchronous handlers fixed
  • Network configuration for CellularInterface

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@VeijoPesonen

@ciarmcom ciarmcom requested review from VeijoPesonen and ARMmbed/mbed-os-maintainers Feb 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@bridadan
Copy link
Contributor

left a comment

Only config has changed, I don't believe this needs tool team approval.

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-netsocket branch Feb 11, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@VeijoPesonen os.mbed.com seems to fail for tls-handshake-invalid (at least occasionally), should we use mbed.com in that test case?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

@VeijoPesonen os.mbed.com seems to fail for tls-handshake-invalid (at least occasionally), should we use mbed.com in that test case?
@michalpasztamobica , you have an opinion on this one? I haven't done anything for TLSSocket cases myself.

@VeijoPesonen
Copy link
Contributor

left a comment

Please update the changed values to the netsocket test case specification - TESTS/netsocket/README.md.

TESTS/netsocket/tls/tlssocket_handshake_invalid.cpp Outdated
@@ -32,7 +32,7 @@ void TLSSOCKET_HANDSHAKE_INVALID()
TEST_ASSERT_EQUAL(NSAPI_ERROR_OK, sock.open(NetworkInterface::get_default_instance()));
TEST_ASSERT_EQUAL(NSAPI_ERROR_OK, sock.set_root_ca_cert(tls_global::cert));
TEST_ASSERT_EQUAL(NSAPI_ERROR_NO_CONNECTION,
sock.connect("google.com", MBED_CONF_APP_ECHO_SERVER_DISCARD_PORT_TLS));
sock.connect("os.mbed.com", MBED_CONF_APP_ECHO_SERVER_DISCARD_PORT_TLS));

This comment has been minimized.

Copy link
@VeijoPesonen

VeijoPesonen Feb 11, 2019

Contributor

@michalpasztamobica. @SeppoTakalo there was a reason to use google.com?

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Feb 11, 2019

Author Contributor

This might have something to do with IPv6 address resolution, see the comment #9387 (comment)

This comment has been minimized.

Copy link
@michalpasztamobica

michalpasztamobica Feb 11, 2019

Contributor

Yes, os.mbed.com does not accept IPv6 traffic which means it will fail with a different error than we expect. Google.com accepts Ipv6 traffic but will fail due to invalid certificate (which is what we want to test).

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-netsocket branch to b1e5955 Feb 11, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@michalpasztamobica @VeijoPesonen thanks reverted back to google.com.

@michalpasztamobica
Copy link
Contributor

left a comment

Please do not change the TLSSOCKET_HANDHSAKE_INVALID connection back to os.mbed.com. It has to stay with google.com (or some other IPv6-compliant webpage) to pass Nanostack and LWIP6 tests. If necessary, please adjust the documentation. Thanks!

@michalpasztamobica
Copy link
Contributor

left a comment

Just saw your changes, thanks a lot :)

@SeppoTakalo
Copy link
Contributor

left a comment

Small changes requested

Show resolved Hide resolved TESTS/netsocket/udp/udpsocket_sendto_timeout.cpp Outdated
Show resolved Hide resolved tools/test_configs/CellularInterface.json Outdated
Show resolved Hide resolved tools/test_configs/CellularInterface.json Outdated
Show resolved Hide resolved tools/test_configs/CellularInterface.json Outdated

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 11, 2019

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-netsocket branch from b1e5955 Feb 13, 2019

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-netsocket branch to 56badd8 Feb 13, 2019

@cmonr

cmonr approved these changes Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: work labels Feb 13, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 2e9d6d2 into ARMmbed:master Feb 13, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9116 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.