Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUTURE_SEQUANA: SPI HAL fixes #9647

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
5 participants
@lrusinowicz
Copy link
Contributor

lrusinowicz commented Feb 8, 2019

  1. Removed random i/o glitches occurring during device reconfiguration
  2. Fixed hazardous reads occurring at the end of transfer resulting
    in incorrect values being received
  3. Added spi_free() function
  4. Replaced default M0 image with a one ignoring i/o reservation. This is
    a workaround for missing proper destructors in Mbed drivers and BlockDevice
    tests failing on repeated initialization
    Fixes issue #9620.

Test log:
tests_sd_sequana_gcc_20190208.log

Additionally deleted obsolete psoc63_m0_ble_controller_1.01.hex image file.

Description

Pull request type

[x] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

FUTURE_SEQUANA: SPI HAL fixes
1. Removed random i/o glitches occurring during device reconfiguration
2. Fixed hazardous reads occurring at the end of transfer resulting
   in incorrect values being received
3. Added spi_free() function
4. Replaced default M0 image with a one ignoring i/o reservation. This is
   a workaround for missing proper destructors in Mbed drivers and BlockDevice
   tests failing on repeated initialization
Fixes issue #9620.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 8, 2019

@lrusinowicz, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@orenc17
Copy link
Contributor

orenc17 left a comment

I can confirm that this fixes the issue
run sd-example successfully on FUTURE_SEQUANA and FUTURE_SEQUANA_PSA

@lrusinowicz could you also generate new PSA images

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

Ci started

@lrusinowicz

This comment has been minimized.

Copy link
Contributor Author

lrusinowicz commented Feb 11, 2019

@orenc17 This fix doesn't really affect M0 PSA image, which doesn't use SPI. I'm going to submit the fix for PSA deep sleep tests and then will re-generate M0 PSA images with both fixes.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 11, 2019

@0xc0170 0xc0170 merged commit 160a771 into ARMmbed:master Feb 11, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+12 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9846 cycles (-73 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.