Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntelliSense in VSCode export #9649

Merged
merged 3 commits into from Feb 15, 2019

Conversation

Projects
None yet
6 participants
@ngraziano
Copy link
Contributor

ngraziano commented Feb 9, 2019

Allow to use default intelliSenseEngine in visual studio code.
Add of compilerPath and forcedInclude of mbed_config header in the
created c_cpp_properties.json file.

Description

Allow to use default intelliSenseEngine in visual studio code.
Add of compilerPath and forcedInclude of mbed_config header in the
created c_cpp_properties.json file.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 9, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 9, 2019

@ngraziano, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested review from ARMmbed/mbed-os-tools and janjongboom Feb 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

Thanks @ngraziano for the contribution. Our teams will review.

This PR is fixing #7863 ?

@ngraziano

This comment has been minimized.

Copy link
Contributor Author

ngraziano commented Feb 11, 2019

It should fix #7863 (You make me discover this issue).

But when reading #7863 (comment) , I see there is other improvement that can be added to the pull request :

  • I may change ${workspaceRoot} to ${workspaceFolder} (see VSCode Variables Reference)
  • I may change \\ to / on windows configuration to make easier to read.

Do I have to complete this PR or create another one ?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

Can complete it if you have time now, while we review - adding separate commits. As these will be simple fixes

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

release-candidate

Please target master branch

ngraziano added some commits Feb 9, 2019

Fix IntelliSense in VSCode export
Allow to use default intelliSenseEngine in visual studio code.
Add of compilerPath and forcedInclude of mbed_config header in the
created c_cpp_properties.json file.
Vscode export: remove path separator conversion
VSCode handle "/" and it is easier to read.
Vscode export: replace obsolete ${workspaceRoot}
Replace with ${workspaceFolder}

@ngraziano ngraziano changed the base branch from release-candidate to master Feb 11, 2019

@ngraziano ngraziano force-pushed the ngraziano:fix-vscode-export branch to e85bbdd Feb 11, 2019

@ngraziano

This comment has been minimized.

Copy link
Contributor Author

ngraziano commented Feb 11, 2019

It should target master now.

@cmonr

cmonr approved these changes Feb 11, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

@janjongboom Would you be able to locally test this PR on your machine to conform the VSCode changes?

@theotherjimmy
Copy link
Contributor

theotherjimmy left a comment

Thanks for the fix!

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 15, 2019

@janjongboom Would you be able to locally test this PR on your machine to conform the VSCode changes?

While we are waiting, I'll start CI

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 15, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 5a8970a into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/build-ARMC6 Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/cloud-client-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/exporter Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/greentea-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/mbed2-build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/mbed2-build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/mbed2-build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9649/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10274 cycles (+524 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.