Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs in secure targets file filtering #9652

Merged
merged 3 commits into from Feb 11, 2019

Conversation

Projects
None yet
7 participants
@orenc17
Copy link
Contributor

orenc17 commented Feb 10, 2019

Description

During the TF-m bring-up we found issues with the scanning rules

This PR fixes those by:

  • Force adding mbed-os root to include dirs
  • Check source relative to ROOT on secure targets

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @mikisch81

@orenc17 orenc17 changed the title Fix minnor bugs in secure targets file filtering Fix minor bugs in secure targets file filtering Feb 10, 2019

Check source relative to ROOT on secure targets
When building secure targets, we would like compile only files that are in the the mbe-os root folder.
This Fixes an issue when sending multiple --source parameters that are all inside the mbed-os tree

@orenc17 orenc17 force-pushed the kfnta:tools_fixes branch to 0ca2615 Feb 10, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 10, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6
@mikisch81
Copy link
Contributor

mikisch81 left a comment

LGTM

@ciarmcom ciarmcom requested review from mikisch81 , theotherjimmy and ARMmbed/mbed-os-maintainers Feb 10, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 10, 2019

@mikisch81
Copy link
Contributor

mikisch81 left a comment

LGTM

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 10, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@mikisch81

This comment has been minimized.

Copy link
Contributor

mikisch81 commented Feb 11, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 11, 2019

CI started (~4hrs ago)

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr merged commit f04d51b into ARMmbed:master Feb 11, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+48 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9078 cycles (-841 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.