Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Non-IP doxygen updates #9655

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
7 participants
@mirelachirica
Copy link
Contributor

commented Feb 11, 2019

Description

Doxygen updates for cellular Non-IP implementation.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Feb 11, 2019

@ciarmcom

This comment was marked as outdated.

Copy link
Member

commented Feb 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Note, there's a bug in ci script (3 comments - duplication), will be fixed

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Not sure why spellcheck failed for optimisation as it is in our codebase already few times? Can you review?

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

Is it American english only?
Probably the word should be added to the ignore.en.pws

@mirelachirica mirelachirica force-pushed the mirelachirica:nonip_doxygen_updates branch Feb 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Now fixed, optimisation to optimization 👍

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@mirelachirica
s/optimisation/optimization/

@cmonr cmonr added needs: work and removed needs: review labels Feb 15, 2019

@mirelachirica mirelachirica force-pushed the mirelachirica:nonip_doxygen_updates branch to 57a93bb Feb 18, 2019

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 18, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 19, 2019

@cmonr cmonr merged commit e3bc37b into ARMmbed:master Feb 19, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9044 cycles (-1437 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.