Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2351: Fix crypto AC management #9656

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@ccli8
Copy link
Contributor

ccli8 commented Feb 11, 2019

Description

This PR ports #9081 work to NUMAKER_PFM_M2351 target. It majorly includes:

  1. Use mutex to synchronize access to crypto non-SHA AC such as AES, DES, and ECC.
  2. Use atomic flag to synchronize access to crypto SHA AC.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm

ccli8 added some commits Feb 11, 2019

[M2351] Fix crypto AC mgmt
Port of NUC472/M487 crypto AC mgmt work to M2351:
1. Choose mutex to synchronize access to crypto non-SHA AC
2. Choose atomic flag to synchronize access to crypto SHA AC
@@ -19,33 +19,51 @@
#include "mbed_assert.h"
#include "mbed_critical.h"
#include "mbed_error.h"
#if MBED_CONF_RTOS_PRESENT
#include "cmsis_os2.h"

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Feb 11, 2019

Contributor

Is this really needed? You're not using it directly, but maybe something's missing from another header?

This comment has been minimized.

@ccli8

ccli8 Feb 11, 2019

Author Contributor

@kjbracey-arm I removed them.

#if MBED_CONF_RTOS_PRESENT
#include "cmsis_os2.h"
#endif
#include <string.h>

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Feb 11, 2019

Contributor

Ditto - you're not adding anything using it that I can see.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-crypto Feb 11, 2019

@Patater
Copy link
Contributor

Patater left a comment

LGTM

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 11, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 11, 2019

@cmonr cmonr merged commit 1712a2b into ARMmbed:master Feb 12, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-48 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9295 cycles (+58 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 12, 2019

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_m2351_fix-crypto-ac-mgmt branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.