Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MIMXRT1050_EVK: Add IAR support in the exporter" #9657

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
6 participants
@0xc0170
Copy link
Member

0xc0170 commented Feb 11, 2019

Description

Reverts #9496

Reason: MCU is only available in IAR 8.22 and higher. Please see 9610 for more details

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 11, 2019

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-tools Feb 11, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-tools Feb 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member Author

0xc0170 commented Feb 11, 2019

To fix the nightly, I started CI

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 11, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Feb 11, 2019

@0xc0170 Please add the missing template header ;-)

@bridadan
Copy link
Contributor

bridadan left a comment

The changes themselves are fine. Just be sure we don't forget to put this back once we have IAR 8 support!

@0xc0170

This comment has been minimized.

Copy link
Member Author

0xc0170 commented Feb 11, 2019

@0xc0170 Please add the missing template header ;-)

Not sure how that happen , fixed now

It could be if revert via github, it wont catch the template? or I just removed it when typing

@ARMmbed ARMmbed deleted a comment from ciarmcom Feb 11, 2019

@ARMmbed ARMmbed deleted a comment from ciarmcom Feb 11, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 11, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Feb 11, 2019

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 11, 2019

@cmonr cmonr merged commit 760aadf into master Feb 11, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+12 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10475 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 11, 2019

@0xc0170 0xc0170 deleted the revert-9496-Add_MXRT_IAR_Support branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.