Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker files for LPC11U68 and LPC1549 updated #9667

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
7 participants
@deepikabhavnani
Copy link
Contributor

commented Feb 11, 2019

Description

Update linker files and resolve build issue
Linker files for LPC11U68 and LPC1549 updated as Mbed OS memory model

  1. LPC1549 - Has multiple memory banks, 4K bank used for stack exclusively and 16K for Heap. Its is mbed 2 only target hence 4K for stack.
  2. LPC11U68 - Added Heap and Stack sections in linker files. Resolved build issues.

Dependent on : #9571

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108 @mprse

Targeted for Minor release - As dependent on #9571

Update linker files and resolve build issue
Linker files for LPC11U68 and LPC1549 updated as Mbed OS memory model
1.	LPC1549
Has multiple memory banks, 4K bank used for stack exclusively and 16K for Heap
Its is mbed 2 only target hence 4K for stack.

2.	LPC11U68
Added Heap and Stack sections in linker files. Resolved build issues.

@ciarmcom ciarmcom requested review from mprse and ARMmbed/mbed-os-maintainers Feb 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@deepikabhavnani, thank you for your changes.
@mprse @ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested a review from ARMmbed/team-nxp Feb 12, 2019

@mprse

mprse approved these changes Feb 14, 2019

Copy link
Member

left a comment

Looks good!

@@ -511,6 +511,9 @@
"SLEEP",
"SPI"
],
"macros": [

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Feb 14, 2019

Member

why are we adding this macro?

This comment has been minimized.

Copy link
@deepikabhavnani

deepikabhavnani Feb 14, 2019

Author Contributor

As part of linker file updates #9571, it was discovered that these 2 targets needed additional fixes. Hence separate PR was created.

LPC11U68 had build issues - to resolve that Stack and heap section was added to linker file and MBED_FAULT_HANDLER_DISABLED was disabled.

Issues were communicated and resolved over mail with NXP.

This comment has been minimized.

Copy link
@deepikabhavnani

deepikabhavnani Feb 14, 2019

Author Contributor

If this PR is approved, I can cherry-pick commits and apply them on #9571, if approval for 9571 takes more than a week

@cmonr

cmonr approved these changes Feb 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

#9667 (comment)

Let's move forward with that, since this PR feels ready.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@ARMmbed/mbed-os-maintainers - We can merge this PR, this PR is in line to changes of other PR (not directly dependent). We just need to be sure that both of them are for minor release.

@cmonr cmonr merged commit 31519ef into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9128 cycles (-622 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:NXP_linker branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.