Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Py3.7 mdot target build #9673

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
6 participants
@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

Description

Fixes #8618

In addition to the byte/string issue, there was an additional decode that is no longer needed.

Tested with mbed test --compile -m GCC_ARM -t MTS_MDOT_F411RE and pytest (reference .travis.yml for command)

  • Succeeds with both 2.7.15 and 3.7.2

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@cmonr cmonr requested a review from ARMmbed/mbed-os-tools Feb 12, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

3 similar comments
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Feb 12, 2019

Also fixes #9618

Two birds with one stone ^_^

@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Feb 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 12, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Feb 12, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr cmonr force-pushed the cmonr:fix-py3-MDOT-build branch to b59bb46 Feb 12, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor Author

cmonr commented Feb 12, 2019

CI started

@alekla01

This comment has been minimized.

Copy link
Contributor

alekla01 commented Feb 12, 2019

Restarted CI after #9677

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 12, 2019

@cmonr cmonr merged commit 3d7995e into ARMmbed:master Feb 13, 2019

15 checks passed

continuous-integration/jenkins/pr-head @cmonr: Jenkins did not update any statuses, unsure why. Isolated incident
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9096 cycles (-1003 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.