Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enet_tasklet_disconnect() should generate event to tasklet. #9684

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
7 participants
@KariHaapalehto
Copy link
Contributor

commented Feb 12, 2019

enet_tasklet_disconnect() is now generating event to ethernet_tasklet,
which will then handle it.

Description

Correction is tested manually, using K64F&Ethernet and UBLOX_ODIN_W2&Wifi

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@KariHaapalehto, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@KariHaapalehto, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@@ -28,7 +28,8 @@ extern "C" {
enum {
APPL_EVENT_CONNECT = 0x01,
APPL_BACKHAUL_INTERFACE_PHY_DOWN,
APPL_BACKHAUL_INTERFACE_PHY_UP

This comment has been minimized.

Copy link
@michalpasztamobica

michalpasztamobica Feb 12, 2019

Contributor

I don't fully understand why we don't distinguish APPL_BACKHAUL_INTERFACE_PHY_UP (interface swithced on, but cable not necessarily connected) and APPL_BACKHAUL_LINK_UP (cable connected)?

This comment has been minimized.

Copy link
@cmonr

This comment has been minimized.

Copy link
@KariHaapalehto

KariHaapalehto Feb 14, 2019

Author Contributor

There haven't been need for that yet, from the connection staus point of view

enet_tasklet_disconnect() should generate event to tasklet.
enet_tasklet_disconnect() is now generating event to ethernet_tasklet,
which will then handle it.

@KariHaapalehto KariHaapalehto force-pushed the KariHaapalehto:ethernet_tasklet_correction branch to 31c4013 Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

CI started whilst final review response comes in

@cmonr

cmonr approved these changes Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

Marking for 5.12.

Or @KariHaapalehto, is there a reason this should go into a patch? I wasn't able to find out why this should be generating the event.

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@KariHaapalehto

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

This event generation will fix the race condition of nanostack interface.
Also this will fix the issue which has been found in our internal testing https://jira.arm.com/browse/ONME-4155

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 14, 2019

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 14, 2019

@cmonr cmonr merged commit 3944165 into ARMmbed:master Feb 14, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9276 cycles (-69 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.